Skip to content

Commit b4738bc

Browse files
committed
Add comments as to why this is necessary
Signed-off-by: Derek Ho <dxho@amazon.com>
1 parent 7eedb69 commit b4738bc

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/actions/install-dashboards/action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,4 +82,4 @@ runs:
8282
with:
8383
timeout_minutes: 20
8484
max_attempts: 2
85-
command: yarn --cwd OpenSearch-Dashboards osd bootstrap --oss --single-version=loose
85+
command: yarn --cwd OpenSearch-Dashboards osd bootstrap --oss --single-version=loose # loose is passed in to ignore version conflicts on cypress version used in OSD and this repo

.github/workflows/verify-binary-installation.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,15 @@ jobs:
8585
node-version: ${{ steps.tool-versions.outputs.node_version }}
8686
registry-url: 'https://registry.npmjs.org'
8787

88+
# loose is passed in to ignore version conflicts on cypress version used in OSD and this repo
8889
- name: Setup Opensearch Dashboards
8990
run: |
9091
npm uninstall -g yarn
9192
echo "Installing yarn ${{ steps.tool-versions.outputs.yarn_version }}"
9293
npm i -g yarn@${{ steps.tool-versions.outputs.yarn_version }}
9394
yarn cache clean
9495
yarn add sha.js
95-
yarn osd bootstrap --single-version=loose
96+
yarn osd bootstrap --single-version=loose
9697
scripts/use_node scripts/build
9798
working-directory: OpenSearch-Dashboards
9899
shell: bash
@@ -101,6 +102,7 @@ jobs:
101102
with:
102103
path: OpenSearch-Dashboards/plugins/security-dashboards-plugin
103104

105+
# loose is passed in to ignore version conflicts on cypress version used in OSD and this repo
104106
- name: Install dependencies
105107
run: |
106108
yarn osd bootstrap --single-version=loose

0 commit comments

Comments
 (0)