You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation uses the isTopQueriesIndex function to filter indices when deleting outdated data. While this approach works currently, it presents a potential risk as the codebase evolves. If we modify index settings or patterns and update this function without careful consideration, we might inadvertently delete data from unrelated indices, as we currently iterate through all indices in the cluster.
What solution would you like?
Replace the broad clusterService.state().metadata().indices() approach to get delete candidates with a more targeted method that only considers indices matching our specific pattern, something like:
This can limit deletion candidates exclusively to indices matching the top queries pattern, creating a safer boundary for our deletion operations.
What alternatives have you considered?
We could maintain the current implementation, but this would perpetuate the risk of potential data loss as the software evolves, particularly during refactoring or feature expansion.
Do you have any additional context?
This change follows the principle of least privilege by limiting the scope of our deletion operations to only the indices we intend to manage.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem?
The current implementation uses the
isTopQueriesIndex
function to filter indices when deleting outdated data. While this approach works currently, it presents a potential risk as the codebase evolves. If we modify index settings or patterns and update this function without careful consideration, we might inadvertently delete data from unrelated indices, as we currently iterate through all indices in the cluster.What solution would you like?
Replace the broad
clusterService.state().metadata().indices()
approach to get delete candidates with a more targeted method that only considers indices matching our specific pattern, something like:This can limit deletion candidates exclusively to indices matching the top queries pattern, creating a safer boundary for our deletion operations.
What alternatives have you considered?
We could maintain the current implementation, but this would perpetuate the risk of potential data loss as the software evolves, particularly during refactoring or feature expansion.
Do you have any additional context?
This change follows the principle of least privilege by limiting the scope of our deletion operations to only the indices we intend to manage.
The text was updated successfully, but these errors were encountered: