Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Extract common data models + OS Collectors + Service Metrics #2

Closed
khushbr opened this issue Apr 7, 2023 · 2 comments
Closed
Labels
enhancement New feature or request v2.8.0 Issues and PRs related to version v2.8.0

Comments

@khushbr
Copy link
Collaborator

khushbr commented Apr 7, 2023

Background Context
Performance Analyzer (Writer) plugin captures the system behavior at a fine grain(5s) level in the form of metrics and stats, which is periodically flushed to a shared memory location. The RCA Agent(Reader) component scans this directory for updates, parses the raw data into sqlite entries and populates the on-disk sqlite metricDB.

MetricsProcessor

Problem Statement & Proposed Solution
In the past, a conscious design choice to segregate the OpenSearch independent code into a separate process(RCA) was made. This allowed to deploy changes to RCA without restarting the critical OpenSearch process. However, the code split wasn't done cleanly. The shared data models of the various metrics are currently part of the RCA codebase. This proposal is to address this circular dependency between PA and RCA, extracting out the common data models from RCA codebase to a shared library performance-analyzer-commons, this can in-turn be consumed by the 2 components.

@khushbr khushbr added the enhancement New feature or request label Apr 7, 2023
@khushbr
Copy link
Collaborator Author

khushbr commented Apr 7, 2023

Sister issue on RCA: opensearch-project/performance-analyzer-rca#307

@khushbr khushbr added the v2.8.0 Issues and PRs related to version v2.8.0 label Apr 7, 2023
@khushbr khushbr changed the title [FEATURE] Extract common data models [FEATURE] Extract common data models + OS Collectors + Service Metrics May 30, 2023
@khushbr
Copy link
Collaborator Author

khushbr commented May 31, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.8.0 Issues and PRs related to version v2.8.0
Projects
None yet
Development

No branches or pull requests

1 participant