-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROPOSAL] Release v. Next #48
Comments
Just copy-pasting this my comment: My initial idea was quite similar, and what I was actually trying to do was something like this: signer = Aws::Sigv4::Signer.new(...)
transport = OpenSearch::Transport::HTTP::Faraday.new(
url: 'http://localhost:9200',
options: {
headers: { 'Content-Type' => 'application/json' },
transport_options: {
ssl: { verify: false }
}
}
)
sigv4_signing_transport_decorator = OpenSearch::Aws::Transport::Transport::Sigv4SigningTransportDecorator.new(transport, signer)
client = OpenSearch::Client.new({ transport: sigv4_signing_transport_decorator }) This decorator simply receives |
@dblock I briefly read through the source code of
The final layer, This means that the second layer, My previous PR solves this in a somewhat forceful way, but how about extending it in the following manner? client = OpenSearch::Client.new(...)
signer = Aws::Sigv4::Signer.new(...)
OpenSearch::AWS::Sigv4::enable_sigv4_to_client(client, signer) What we're doing here is simple: just extending the instance method |
@issei-m this is being blocked by opensearch-project/opensearch-build#5417 |
What/Why
What are you proposing?
Release v. next before merging #47.
What users have asked for this feature?
Fixes #46.
The text was updated successfully, but these errors were encountered: