From 0c0684c7a797699a471579ca26c95cdd66e8a874 Mon Sep 17 00:00:00 2001 From: Shenoy Pratik Date: Thu, 15 Feb 2024 23:27:29 -0800 Subject: [PATCH 1/3] increase delay times in gantt charts Signed-off-by: Shenoy Pratik (cherry picked from commit 508fd25707f7cfbb49b4df3653a813f0734e3f6c) --- .../plugins/gantt-chart-dashboards/gantt_ui.spec.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js b/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js index 29251e3c2..170d465f0 100644 --- a/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js +++ b/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js @@ -11,7 +11,7 @@ import { BASE_PATH } from '../../../utils/constants'; dayjs.extend(customParseFormat); -const delay = 100; +const delay = 5000; const GANTT_VIS_NAME = 'A test gantt chart ' + Math.random().toString(36).substring(2); const Y_LABEL = 'A unique label for Y-axis'; @@ -57,10 +57,11 @@ describe('Dump test data', () => { describe('Save a gantt chart', () => { beforeEach(() => { cy.visit(`${BASE_PATH}/app/visualize#`); + cy.wait(delay); }); it('Creates and saves a gantt chart', () => { - cy.get('.euiButton__text').contains('Create ').click({ force: true }); + cy.contains('Create visualization').click({ force: true }); cy.wait(delay); cy.get('[data-test-subj="visTypeTitle"]') .contains('Gantt Chart') @@ -83,8 +84,10 @@ describe('Save a gantt chart', () => { describe('Render and configure a gantt chart', () => { beforeEach(() => { + cy.wait(delay); cy.visit(`${BASE_PATH}/app/visualize#`); cy.contains(GANTT_VIS_NAME).click({ force: true }); + cy.wait(delay); }); it('Renders no data message', () => { @@ -114,7 +117,7 @@ describe('Render and configure a gantt chart', () => { cy.wait(delay); cy.get('.traces').should('have.length', DEFAULT_SIZE); - + cy.wait(delay); cy.get('.euiButton__text').contains('Save').click({ force: true }); cy.wait(delay); cy.get('button[data-test-subj="confirmSaveSavedObjectButton"]').click({ @@ -128,6 +131,7 @@ describe('Configure panel settings', () => { cy.visit(`${BASE_PATH}/app/visualize#`); cy.contains(GANTT_VIS_NAME).click({ force: true }); cy.contains('Panel settings').click({ force: true }); + cy.wait(delay); }); it('Changes y-axis label', () => { @@ -244,7 +248,7 @@ describe('Configure panel settings', () => { describe('Add gantt chart to dashboard', () => { it('Adds gantt chart to dashboard', () => { cy.visit(`${BASE_PATH}/app/dashboards#/create`); - + cy.wait(delay); cy.contains('Add an existing').click({ force: true }); cy.wait(delay); cy.get('input[data-test-subj="savedObjectFinderSearchInput"]') From 131c81dd269fc4798c75136caedacd69b0a1b142 Mon Sep 17 00:00:00 2001 From: Shenoy Pratik Date: Thu, 15 Feb 2024 23:48:23 -0800 Subject: [PATCH 2/3] update create button text Signed-off-by: Shenoy Pratik --- .../integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js b/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js index 170d465f0..6ade369d2 100644 --- a/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js +++ b/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js @@ -61,7 +61,7 @@ describe('Save a gantt chart', () => { }); it('Creates and saves a gantt chart', () => { - cy.contains('Create visualization').click({ force: true }); + cy.contains('Create ').click({ force: true }); cy.wait(delay); cy.get('[data-test-subj="visTypeTitle"]') .contains('Gantt Chart') From c2d562182bbe76949f5ea15b925071d59c3df47a Mon Sep 17 00:00:00 2001 From: Shenoy Pratik Date: Fri, 16 Feb 2024 04:57:35 -0800 Subject: [PATCH 3/3] revert create button change Signed-off-by: Shenoy Pratik --- .../integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js b/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js index 6ade369d2..914ada7c3 100644 --- a/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js +++ b/cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js @@ -61,7 +61,7 @@ describe('Save a gantt chart', () => { }); it('Creates and saves a gantt chart', () => { - cy.contains('Create ').click({ force: true }); + cy.get('.euiButton__text').contains('Create ').click({ force: true }); cy.wait(delay); cy.get('[data-test-subj="visTypeTitle"]') .contains('Gantt Chart')