fix flaky observability 1.3 tests (#1742)

Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
Co-authored-by: Ritvi Bhatt <ribhatt@amazon.com>

Author: ritvibhatt

.github/workflows/cypress-workflow-bundle-snapshot-based.yml

@@ -75,13 +75,13 @@ jobs:
           command: yarn cypress:run-with-security --spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/*.js'
           wait-on: 'http://localhost:5601'
       # Screenshots are only captured on failure, will change this once we do visual regression tests
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: cypress-screenshots
           path: monterey-test/cypress/screenshots
       # Test run video was always captured, so this action uses "always()" condition
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: cypress-videos

.github/workflows/cypress-workflow-plugins-bundle-snapshot-based.yml

@@ -76,13 +76,13 @@ jobs:
           command: yarn cypress:run-plugin-tests-with-security
           wait-on: 'http://localhost:5601'
       # Screenshots are only captured on failure, will change this once we do visual regression tests
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: cypress-screenshots
           path: monterey-test/cypress/screenshots
       # Test run video was always captured, so this action uses "always()" condition
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: cypress-videos

.github/workflows/cypress-workflow-vanilla-snapshot-based.yml

@@ -74,19 +74,19 @@ jobs:
           command: yarn cypress:run-without-security --browser chromium --spec 'cypress/integration/core-opensearch-dashboards/vanilla-opensearch-dashboards/*.js'
           wait-on: 'http://localhost:5601'
       # Screenshots are only captured on failure, will change this once we do visual regression tests
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: cypress-screenshots
           path: monetery-test/cypress/screenshots
       # Test run video was always captured, so this action uses "always()" condition
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: cypress-videos
           path: monetery-test/cypress/videos
       # Test reports was always captured, so this action uses "always()" condition
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: cypress-results

cypress/integration/plugins/observability-dashboards/3_trace_analytics_traces.spec.js

@@ -35,7 +35,6 @@ describe('Testing traces table', () => {
 
   it('Renders the traces table', () => {
     cy.contains(' (108)').should('exist');
-    cy.contains('03/25/2021 10:23:45').should('exist');
     cy.contains('03f9c770db5ee2f1caac0...').should('exist');
     cy.contains('224.99').should('exist');
 
@@ -50,7 +49,6 @@ describe('Testing traces table', () => {
     cy.get('.euiButton__text').contains('Refresh').click();
     cy.wait(delayTime);
     cy.contains(' (1)').should('exist');
-    cy.contains('03/25/2021 10:21:22').should('exist');
   });
 });
 
@@ -67,7 +65,6 @@ describe('Testing trace view', () => {
   it('Renders the trace view', () => {
     cy.contains('43.75%').should('exist');
     cy.contains('42.58%').should('exist');
-    cy.contains('03/25/2021 10:21:22').should('exist');
     cy.get('h2.euiTitle').contains(TRACE_ID).should('exist');
 
     cy.get('div.js-plotly-plot').should('have.length.gte', 2);

cypress/integration/plugins/observability-dashboards/4_panels.spec.js

@@ -217,9 +217,9 @@ describe('Testing a panel', () => {
   });
 
   it('Add existing visualization #1', () => {
-    cy.get('.euiButton__text').contains('Add visualization').click();
+    cy.get('.euiButton__text').contains('Add Visualization').click();
     cy.wait(panelDelay);
-    cy.get('.euiContextMenuItem__text').contains('Select existing visualization').click();
+    cy.get('.euiContextMenuItem__text').contains('Select Existing Visualization').click();
     cy.wait(panelDelay);
     cy.get('select').select(PPL_VISUALIZATIONS_NAMES[0]);
     cy.get('button[aria-label="refreshPreview"]').click();
@@ -231,9 +231,9 @@ describe('Testing a panel', () => {
   });
 
   it('Add existing visualization #2', () => {
-    cy.get('.euiButton__text').contains('Add visualization').click();
+    cy.get('.euiButton__text').contains('Add Visualization').click();
     cy.wait(panelDelay);
-    cy.get('.euiContextMenuItem__text').contains('Select existing visualization').click();
+    cy.get('.euiContextMenuItem__text').contains('Select Existing Visualization').click();
     cy.wait(panelDelay);
     cy.get('select').select(PPL_VISUALIZATIONS_NAMES[1]);
     cy.get('button[aria-label="refreshPreview"]').click();
@@ -245,7 +245,7 @@ describe('Testing a panel', () => {
   });
 
   it('Add ppl filter to panel', () => {
-    cy.get('[data-test-subj="searchAutocompleteTextArea"]').type("where Carrier = 'OpenSearch-Air'| where Dest = 'Munich Airport'", { delay: TYPING_DELAY });
+    cy.get('[data-test-subj="searchAutocompleteTextArea"]').type("{selectall}{backspace}where Carrier = 'OpenSearch-Air'| where Dest = 'Munich Airport'", { delay: TYPING_DELAY });
     cy.get('.euiButton__text').contains('Refresh').click();
     cy.wait(panelDelay * 3);
     cy.get('.xtick').should('contain', 'OpenSearch-Air');
@@ -331,9 +331,9 @@ describe('Testing a panel', () => {
   });
 
   it('Create new visualization and add to panel', () => {
-    cy.get('.euiButton__text').contains('Add visualization').click();
+    cy.get('.euiButton__text').contains('Add Visualization').click();
     cy.wait(panelDelay);
-    cy.get('.euiContextMenuItem__text').contains('Create new visualization').click();
+    cy.get('.euiContextMenuItem__text').contains('Create New Visualization').click();
     cy.wait(panelDelay * 3);
     cy.url().should('match', new RegExp('(.*)#/event_analytics/explorer'));
     cy.get('[id^=autocomplete-textarea]').type(PPL_VISUALIZATIONS[2]);
@@ -382,6 +382,7 @@ describe('Testing a panel', () => {
 
 describe('Add samples and clean up all test data', () => {
   it('Add sample data', () => {
+    cy.route2('**/api/observability/operational_panels/panels/addSamplePanels').as('samplePanels');
     moveToPanelHome();
     cy.get('.euiButton__text').contains('Actions').click();
     cy.wait(panelDelay);
@@ -392,9 +393,7 @@ describe('Add samples and clean up all test data', () => {
       .should('exist');
     cy.wait(panelDelay);
     cy.get('.euiButton__text').contains('Yes').click();
-    cy.wait(panelDelay * 5);
-    cy.get('.euiTableCellContent').contains(SAMPLE_PANEL).should('exist');
-    cy.wait(panelDelay);
+    cy.wait('@samplePanels').its('response.statusCode').should('eq', 200);
   });
 
   it('Validate sample data', () => {

cypress/integration/plugins/observability-dashboards/5_event_analytics.spec.js

@@ -336,7 +336,7 @@ describe('Switch on and off livetail', () => {
     cy.get('[data-test-subj="searchAutocompleteTextArea"]').type(TEST_QUERIES[1].query);
 
     cy.get('[data-test-subj=eventLiveTail]').click();
-    cy.get('[data-test-subj=eventLiveTail__delay10s]').click();
+    cy.get('[data-test-subj=eventLiveTail__delay10]').click();
     cy.wait(delayTime * 2);
     cy.get('.euiToastHeader__title').contains('On').should('exist');
 
@@ -355,7 +355,7 @@ describe('Live tail stop automatically', () => {
     cy.get('[data-test-subj="searchAutocompleteTextArea"]').type(TEST_QUERIES[1].query);
 
     cy.get('[data-test-subj=eventLiveTail]').click();
-    cy.get('[data-test-subj=eventLiveTail__delay10s]').click();
+    cy.get('[data-test-subj=eventLiveTail__delay10]').click();
     cy.wait(delayTime * 2);
     cy.get('.euiToastHeader__title').contains('On').should('exist');
   });

cypress/utils/plugins/observability-dashboards/constants.js

@@ -37,8 +37,8 @@ export const testIndexDataSet = [
 ]
 
 export const setTimeFilter = (setEndTime = false, refresh = true) => {
-  const startTime = 'Mar 25, 2021 @ 10:00:00.000';
-  const endTime = 'Mar 25, 2021 @ 11:00:00.000';
+  const startTime = 'Mar 24, 2021 @ 00:00:00.000';
+  const endTime = 'Mar 26, 2021 @ 00:00:00.000';
   cy.get('button.euiButtonEmpty[aria-label="Date quick select"]').click();
   cy.get('.euiQuickSelect__applyButton').click();
   cy.get('.euiSuperDatePicker__prettyFormatLink').click();