[BUG]Reports flakey test fix for 2.5 (#1728)

* Reports falkey test fix

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* chamged workflow

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

---------

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

Author: sumukhswamy

.github/workflows/release-e2e-workflow-template.yml

@@ -113,19 +113,19 @@ jobs:
           command: ${{ inputs.test-command }}
           wait-on: 'http://localhost:5601'
       # Screenshots are only captured on failure, will change this once we do visual regression tests
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: cypress-screenshots
           path: cypress-test/cypress/screenshots
       # Test run video was always captured, so this action uses "always()" condition
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: cypress-videos
           path: cypress-test/cypress/videos
       # Test reports was always captured, so this action uses "always()" condition
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: cypress-results

cypress/integration/plugins/reports-dashboards/04-download.spec.js

@@ -28,6 +28,9 @@ describe('Cypress', () => {
   });
 
   it('Download from reporting homepage', () => {
+    cy.intercept('GET', `${BASE_PATH}/api/reporting/generateReport/*`).as(
+      'generateReport'
+    );
     cy.visit(`${BASE_PATH}/app/reports-dashboards#/`, {
       waitForGetTenant: true,
     });
@@ -40,13 +43,7 @@ describe('Cypress', () => {
     cy.get('[id="landingPageOnDemandDownload"]')
       .contains('PDF')
       .click({ force: true });
-    cy.get('body').then(($body) => {
-      if ($body.find('#downloadInProgressLoadingModal').length > 0) {
-        return;
-      } else {
-        assert(false);
-      }
-    });
+    cy.wait('@generateReport').its('response.statusCode').should('eq', 200);
   });
 
   it('Download pdf from in-context menu', () => {