Add further creation waits to notebooks tests (#1270)

* Replace refresh with wait for creation

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Remove unused variable

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Re-add refresh/reload with issue ref

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Revert "Re-add refresh/reload with issue ref"

This reverts commit 6dca5a7.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

---------

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
(cherry picked from commit 8014ae0)

Author: Swiddis

cypress/integration/plugins/observability-dashboards/6_notebooks.spec.js

@@ -10,7 +10,6 @@ import {
   BASE_PATH,
   delayTime,
   MARKDOWN_TEXT,
-  OBSERVABILITY_INDEX_NAME,
 } from '../../../utils/constants';
 
 import { skipOn } from '@cypress/skip-test';
@@ -33,22 +32,7 @@ const makeTestNotebook = () => {
   cy.get('input[data-test-subj="custom-input-modal-input"]').type(notebookName);
   cy.get('button[data-test-subj="custom-input-modal-confirm-button"]').click();
 
-  // Force refresh the observablity index and reload page to load notebooks.
-  cy.request({
-    method: 'POST',
-    failOnStatusCode: false,
-    form: false,
-    url: 'api/console/proxy',
-    headers: {
-      'content-type': 'application/json;charset=UTF-8',
-      'osd-xsrf': true,
-    },
-    qs: {
-      path: `${OBSERVABILITY_INDEX_NAME}/_refresh`,
-      method: 'POST',
-    },
-  });
-  cy.reload();
+  cy.contains(`Notebook "${notebookName}" successfully created`);
 
   cy.get('h1[data-test-subj="notebookTitle"]')
     .contains(notebookName)