fix: flaky tests in discover.spec.js (#1033) (#1056)

* fix: manually set global as default tenant

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: add delay to ensure the input is right

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add some comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 94a5d3c)

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>

Author: opensearch-trigger-bot[bot]

cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/discover.spec.js

@@ -26,6 +26,17 @@ const indexSet = [
 
 describe('discover app', { scrollBehavior: false }, () => {
   before(() => {
+    if (Cypress.env('SECURITY_ENABLED')) {
+      /**
+       * Security plugin is using private tenant as default.
+       * So here we'd need to set global tenant as default manually.
+       */
+      cy.changeDefaultTenant({
+        multitenancy_enabled: true,
+        private_tenant_enabled: true,
+        default_tenant: 'global',
+      });
+    }
     CURRENT_TENANT.newTenant = 'global';
     // import logstash functional
     testFixtureHandler.importJSONDocIfNeeded(

cypress/utils/dashboards/commands.js

@@ -79,7 +79,10 @@ Cypress.Commands.add('setTopNavDate', (start, end, submit = true) => {
   cy.getElementByTestId('superDatePickerAbsoluteDateInput', opts)
     .click(opts)
     .clear(opts)
-    .type(start, opts);
+    .type(start, {
+      ...opts,
+      delay: 0, // add a delay here, cypress sometimes fails to type all the content into the input.
+    });
 
   // Click end date
   cy.getElementByTestId('superDatePickerendDatePopoverButton', opts)
@@ -96,7 +99,10 @@ Cypress.Commands.add('setTopNavDate', (start, end, submit = true) => {
     .last(opts)
     .click(opts)
     .clear(opts)
-    .type(end, opts);
+    .type(end, {
+      ...opts,
+      delay: 0, // add a delay here, cypress sometimes fails to type all the content into the input.
+    });
 
   // Close popup
   cy.getElementByTestId('superDatePickerendDatePopoverButton', opts).click(