Skip to content

Commit 6918ca9

Browse files
Update manifest repopath and temp resolve osd compiling issues on qualifier
1 parent f6dc2e7 commit 6918ca9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/build_workflow/builder_from_source.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
class BuilderFromSource(Builder):
2323
def checkout(self, work_dir: str) -> None:
24-
# TODO: Reduce temp dir randomized dirname char counts
24+
# TODO: Reduce temp dir randomized dirname char counts or remove this after qualifier
2525
# This is a temporary fix for OSD Core
2626
# Due to path of node installation is longer than 200 chars and cause path not able to be removed
2727
# https://github.com/opensearch-project/OpenSearch-Dashboards/issues/9397#issuecomment-2727641857

src/system/temporary_directory.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class TemporaryDirectory:
4141
def __init__(self, keep: bool = False, chdir: bool = False) -> None:
4242
self.keep = keep
4343
if current_platform() == "windows":
44-
windows_home_dir = os.path.abspath("C:\\") # Further reduce char counts on windows path
44+
windows_home_dir = os.path.abspath("C:\\") # Reduce char counts on windows path
4545
self.name = tempfile.mkdtemp(dir=windows_home_dir)
4646
else:
4747
self.name = tempfile.mkdtemp()

0 commit comments

Comments
 (0)