Skip to content

Commit f9ee4e6

Browse files
author
Ian Hoang
committed
Rename is_valid() to is_valid_index() in extractors.py and update comment based on feedback
Signed-off-by: Ian Hoang <hoangia@amazon.com>
1 parent d62990d commit f9ee4e6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

osbenchmark/workload_generator/extractors.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def extract_indices(self, workload_path):
5050
def extract(self, outdir, index_pattern):
5151
"""
5252
Extracts and writes index settings and
53-
mappings to "index.json" in a workload
53+
mappings to "<index_name>.json" in a workload
5454
:param outdir: destination directory
5555
:param index_pattern: name of index or index pattern
5656
:return: Dictionary of template variables corresponding to the
@@ -85,7 +85,7 @@ def extract_index_mapping_and_settings(self, index_pattern):
8585
# the response might contain multiple indices if a wildcard was provided
8686
response = self.client.indices.get(index_pattern)
8787
for index, details in response.items():
88-
valid, reason = self.is_valid(index)
88+
valid, reason = self.is_valid_index(index)
8989
if valid:
9090
mappings = details["mappings"]
9191
index_settings = self.filter_ephemeral_index_settings(details["settings"]["index"])
@@ -122,7 +122,7 @@ def update_index_setting_parameters(self, settings):
122122
settings[s] = param.format(orig=orig_value)
123123

124124

125-
def is_valid(self, index_name):
125+
def is_valid_index(self, index_name):
126126
if len(index_name) == 0:
127127
return False, "Index name is empty"
128128
if index_name.startswith("."):

0 commit comments

Comments
 (0)