Skip to content

Commit acdb7f2

Browse files
authoredMay 12, 2023
[Backport 2.x] Baseline owners and maintainers (#170) (#171)
* Baseline owners and maintainers (#170) Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit d933b11) * Add allow_registering_model_via_url as integ test use custom model Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Add hash for test model Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Fix model deployment after recent redeploy feature in ml-commons Signed-off-by: Martin Gaievski <gaievski@amazon.com> --------- Signed-off-by: Martin Gaievski <gaievski@amazon.com>
1 parent e8c732f commit acdb7f2

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed
 

‎.github/CODEOWNERS

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# This should match the owning team set up in https://github.com/orgs/opensearch-project/teams
2-
* @opensearch-project/neural-search
2+
* @heemin32 @navneet1v @VijayanB @vamshin @jmazanec15 @naveentatikonda @junqiu-lei @martin-gaievski @sean-zheng-amazon @model-collapse @wujunshen @zane-neo @ylwu-amzn @jngz-es

‎MAINTAINERS.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,8 @@
1111
| Zan Niu | [zane-neo](https://github.com/zane-neo) | Amazon |
1212
| Yaliang Wu | [ylwu-amzn](https://github.com/ylwu-amzn) | Amazon |
1313
| Jing Zhang | [jngz-es](https://github.com/jngz-es) | Amazon |
14-
15-
[This document](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md) explains what maintainers do in this repo, and how they should be doing it. If you're interested in contributing, see [CONTRIBUTING](CONTRIBUTING.md).
14+
| Heemin Kim | [heemin32](https://github.com/heemin32) | Amazon |
15+
| Junqiu Lei | [junqiu-lei](https://github.com/junqiu-lei) | Amazon |
16+
| Martin Gaievski | [martin-gaievski](https://github.com/martin-gaievski) | Amazon |
17+
| Naveen Tatikonda | [naveentatikonda](https://github.com/naveentatikonda) | Amazon |
18+
| Vijayan Balasubramanian| [VijayanB](https://github.com/VijayanB) | Amazon |

‎src/test/java/org/opensearch/neuralsearch/common/BaseNeuralSearchIT.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ public void setupSettings() {
6464
updateClusterSettings("plugins.ml_commons.only_run_on_ml_node", false);
6565
// default threshold for native circuit breaker is 90, it may be not enough on test runner machine
6666
updateClusterSettings("plugins.ml_commons.native_memory_threshold", 100);
67+
updateClusterSettings("plugins.ml_commons.allow_registering_model_via_url", true);
6768
}
6869

6970
@SneakyThrows
@@ -90,7 +91,7 @@ protected String uploadModel(String requestBody) throws Exception {
9091
Response uploadResponse = makeRequest(
9192
client(),
9293
"POST",
93-
"/_plugins/_ml/models/_upload",
94+
"/_plugins/_ml/models/_register",
9495
null,
9596
toHttpEntity(requestBody),
9697
ImmutableList.of(new BasicHeader(HttpHeaders.USER_AGENT, "Kibana"))

‎src/test/java/org/opensearch/neuralsearch/query/NeuralQueryIT.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ public class NeuralQueryIT extends BaseNeuralSearchIT {
4545
@Before
4646
public void setUp() throws Exception {
4747
super.setUp();
48-
if (modelId.get() == null) {
49-
modelId.compareAndSet(null, prepareModel());
50-
}
48+
modelId.compareAndSet(modelId.get(), prepareModel());
5149
}
5250

5351
/**

‎src/test/resources/processor/UploadModelRequestBody.json

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"version": "1.0.0",
44
"model_format": "TORCH_SCRIPT",
55
"model_task_type": "text_embedding",
6+
"model_content_hash_value": "e13b74006290a9d0f58c1376f9629d4ebc05a0f9385f40db837452b167ae9021",
67
"model_config": {
78
"model_type": "bert",
89
"embedding_dimension": 768,

0 commit comments

Comments
 (0)