Skip to content

Commit 837f180

Browse files
committed
Add log to locate data null issue in IT
Signed-off-by: zane-neo <zaniu@amazon.com>
1 parent ce1d250 commit 837f180

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

plugin/src/test/java/org/opensearch/ml/rest/RestBedRockInferenceIT.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -302,10 +302,11 @@ private void validateOutput(String errorMsg, Map<String, Object> output, String
302302
List outputList = (List) output.get("output");
303303
assertEquals(errorMsg, 1, outputList.size());
304304
assertTrue(errorMsg, outputList.get(0) instanceof Map);
305-
String typeErrorMsg = errorMsg
306-
+ " first element in the output list is type of: "
307-
+ ((Map<?, ?>) outputList.get(0)).get("data").getClass().getName();
308-
assertTrue(typeErrorMsg, ((Map<?, ?>) outputList.get(0)).get("data") instanceof List);
305+
assertNotNull(
306+
"data in output list is null which is unexpected, output is: " + StringUtils.gson.toJson(output),
307+
((Map<?, ?>) outputList.get(0)).get("data")
308+
);
309+
assertTrue(errorMsg, ((Map<?, ?>) outputList.get(0)).get("data") instanceof List);
309310
assertEquals(errorMsg, ((Map<?, ?>) outputList.get(0)).get("data_type"), dataType);
310311
}
311312

plugin/src/test/java/org/opensearch/ml/rest/RestCohereInferenceIT.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,11 @@ private void validateOutput(String errorMsg, Map<String, Object> output, String
8888
List outputList = (List) output.get("output");
8989
assertEquals(errorMsg, 2, outputList.size());
9090
assertTrue(errorMsg, outputList.get(0) instanceof Map);
91-
String typeErrorMsg = errorMsg
92-
+ " first element in the output list is type of: "
93-
+ ((Map<?, ?>) outputList.get(0)).get("data").getClass().getName();
94-
assertTrue(typeErrorMsg, ((Map<?, ?>) outputList.get(0)).get("data") instanceof List);
91+
assertNotNull(
92+
"data in output list is null which is unexpected, output is: " + org.opensearch.ml.common.utils.StringUtils.gson.toJson(output),
93+
((Map<?, ?>) outputList.get(0)).get("data")
94+
);
95+
assertTrue(errorMsg, ((Map<?, ?>) outputList.get(0)).get("data") instanceof List);
9596
assertTrue(errorMsg, ((Map<?, ?>) outputList.get(0)).get("data_type").equals(dataType));
9697
}
9798

0 commit comments

Comments
 (0)