Skip to content

Commit 6e3f011

Browse files
dhrubo-osgithub-actions[bot]
authored andcommitted
fixing connector validation (#3461)
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit a6eaf08)
1 parent 2de431e commit 6e3f011

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

plugin/src/main/java/org/opensearch/ml/action/register/TransportRegisterModelAction.java

+13-1
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,19 @@ private void doRegister(MLRegisterModelInput registerModelInput, ActionListener<
270270
mlFeatureEnabledSetting,
271271
ActionListener.wrap(r -> {
272272
if (Boolean.TRUE.equals(r)) {
273-
createModelGroup(registerModelInput, listener);
273+
if (registerModelInput.getModelInterface() == null) {
274+
mlModelManager
275+
.getConnector(
276+
registerModelInput.getConnectorId(),
277+
registerModelInput.getTenantId(),
278+
ActionListener.wrap(connector -> {
279+
updateRegisterModelInputModelInterfaceFieldsByConnector(registerModelInput, connector);
280+
createModelGroup(registerModelInput, listener);
281+
}, listener::onFailure)
282+
);
283+
} else {
284+
createModelGroup(registerModelInput, listener);
285+
}
274286
} else {
275287
listener
276288
.onFailure(

plugin/src/main/java/org/opensearch/ml/model/MLModelManager.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -2066,7 +2066,7 @@ public void getController(String modelId, ActionListener<MLController> listener)
20662066
* @param tenantId tenant id
20672067
* @param listener action listener
20682068
*/
2069-
private void getConnector(String connectorId, String tenantId, ActionListener<Connector> listener) {
2069+
public void getConnector(String connectorId, String tenantId, ActionListener<Connector> listener) {
20702070
GetDataObjectRequest getDataObjectRequest = GetDataObjectRequest
20712071
.builder()
20722072
.index(ML_CONNECTOR_INDEX)

0 commit comments

Comments
 (0)