-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add WithFieldName implementation to KNNQueryBuilder #2385
Labels
Comments
This should be fairly trivial as we already have this information in
@vamshin can you assign? |
I can work on this |
thanks @markwu-sde. Assigning to you |
3 tasks
Wasn't familiar with the version process and was unaware the backport PR was failing tests and so it didn't make it into the 2.x branch. Will manually raise a PR to correct this and get it merged to 2.x. Should we keep this issue open until then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
We'd like to update relevant query builders with
WithFieldName
tag so that Query Insights can get field name information when present.Parent issue: opensearch-project/query-insights#110
What solution would you like?
Add
implements WithFieldName
here:k-NN/src/main/java/org/opensearch/knn/index/query/KNNQueryBuilder.java
Line 71 in 7991350
Example:
https://github.com/opensearch-project/OpenSearch/blob/a609e634a348b76386fb11936bbe8c4b38ea72d0/server/src/main/java/org/opensearch/index/query/MatchQueryBuilder.java#L59
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
WithFieldName interface
The text was updated successfully, but these errors were encountered: