Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add WithFieldName implementation to KNNQueryBuilder #2385

Closed
dzane17 opened this issue Jan 14, 2025 · 4 comments · Fixed by #2398
Closed

[FEATURE] Add WithFieldName implementation to KNNQueryBuilder #2385

dzane17 opened this issue Jan 14, 2025 · 4 comments · Fixed by #2398

Comments

@dzane17
Copy link

dzane17 commented Jan 14, 2025

Is your feature request related to a problem?
We'd like to update relevant query builders with WithFieldName tag so that Query Insights can get field name information when present.

Parent issue: opensearch-project/query-insights#110

What solution would you like?
Add implements WithFieldName here:

public class KNNQueryBuilder extends AbstractQueryBuilder<KNNQueryBuilder> {

Example:
https://github.com/opensearch-project/OpenSearch/blob/a609e634a348b76386fb11936bbe8c4b38ea72d0/server/src/main/java/org/opensearch/index/query/MatchQueryBuilder.java#L59

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
WithFieldName interface

@jmazanec15
Copy link
Member

jmazanec15 commented Jan 14, 2025

This should be fairly trivial as we already have this information in

.

@vamshin can you assign?

@markwu-sde
Copy link
Contributor

I can work on this

@vamshin
Copy link
Member

vamshin commented Jan 16, 2025

thanks @markwu-sde. Assigning to you

@markwu-sde
Copy link
Contributor

markwu-sde commented Feb 7, 2025

Wasn't familiar with the version process and was unaware the backport PR was failing tests and so it didn't make it into the 2.x branch. Will manually raise a PR to correct this and get it merged to 2.x.

Should we keep this issue open until then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants