Skip to content

Commit 3e06458

Browse files
jackiehanyangjackiehanyang
committed
update recency_emphasis to be greater than 1 in test cases
Signed-off-by: Jackie Han <hnyng@amazon.com>
1 parent e33ff46 commit 3e06458

8 files changed

+30
-30
lines changed

‎src/test/java/org/opensearch/ad/model/AnomalyDetectorTests.java

+12-12
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ public void testInvalidShingleSize() throws Exception {
338338
TestHelpers.randomUser(),
339339
null,
340340
TestHelpers.randomImputationOption(featureList),
341-
randomIntBetween(1, 10000),
341+
randomIntBetween(2, 10000),
342342
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
343343
randomIntBetween(1, 1000),
344344
null,
@@ -376,7 +376,7 @@ public void testNullDetectorName() throws Exception {
376376
TestHelpers.randomUser(),
377377
null,
378378
TestHelpers.randomImputationOption(featureList),
379-
randomIntBetween(1, 10000),
379+
randomIntBetween(2, 10000),
380380
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
381381
randomIntBetween(1, 1000),
382382
null,
@@ -414,7 +414,7 @@ public void testBlankDetectorName() throws Exception {
414414
TestHelpers.randomUser(),
415415
null,
416416
TestHelpers.randomImputationOption(featureList),
417-
randomIntBetween(1, 10000),
417+
randomIntBetween(2, 10000),
418418
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
419419
randomIntBetween(1, 1000),
420420
null,
@@ -452,7 +452,7 @@ public void testNullTimeField() throws Exception {
452452
TestHelpers.randomUser(),
453453
null,
454454
TestHelpers.randomImputationOption(featureList),
455-
randomIntBetween(1, 10000),
455+
randomIntBetween(2, 10000),
456456
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
457457
randomIntBetween(1, 1000),
458458
null,
@@ -490,7 +490,7 @@ public void testNullIndices() throws Exception {
490490
TestHelpers.randomUser(),
491491
null,
492492
TestHelpers.randomImputationOption(featureList),
493-
randomIntBetween(1, 10000),
493+
randomIntBetween(2, 10000),
494494
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
495495
randomIntBetween(1, 1000),
496496
null,
@@ -528,7 +528,7 @@ public void testEmptyIndices() throws Exception {
528528
TestHelpers.randomUser(),
529529
null,
530530
TestHelpers.randomImputationOption(featureList),
531-
randomIntBetween(1, 10000),
531+
randomIntBetween(2, 10000),
532532
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
533533
randomIntBetween(1, 1000),
534534
null,
@@ -566,7 +566,7 @@ public void testNullDetectionInterval() throws Exception {
566566
TestHelpers.randomUser(),
567567
null,
568568
TestHelpers.randomImputationOption(featureList),
569-
randomIntBetween(1, 10000),
569+
randomIntBetween(2, 10000),
570570
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
571571
randomIntBetween(1, 1000),
572572
null,
@@ -730,7 +730,7 @@ public void testGetShingleSize() throws IOException {
730730
TestHelpers.randomUser(),
731731
null,
732732
TestHelpers.randomImputationOption(featureList),
733-
randomIntBetween(1, 10000),
733+
randomIntBetween(2, 10000),
734734
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
735735
randomIntBetween(1, 1000),
736736
null,
@@ -766,7 +766,7 @@ public void testGetShingleSizeReturnsDefaultValue() throws IOException {
766766
TestHelpers.randomUser(),
767767
null,
768768
TestHelpers.randomImputationOption(featureList),
769-
randomIntBetween(1, 10000),
769+
randomIntBetween(2, 10000),
770770
seasonalityIntervals,
771771
randomIntBetween(1, 1000),
772772
null,
@@ -832,7 +832,7 @@ public void testNullFeatureAttributes() throws IOException {
832832
TestHelpers.randomUser(),
833833
null,
834834
null,
835-
randomIntBetween(1, 10000),
835+
randomIntBetween(2, 10000),
836836
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
837837
randomIntBetween(1, 1000),
838838
null,
@@ -866,7 +866,7 @@ public void testValidateResultIndex() throws IOException {
866866
TestHelpers.randomUser(),
867867
null,
868868
null,
869-
randomIntBetween(1, 10000),
869+
randomIntBetween(2, 10000),
870870
randomIntBetween(1, TimeSeriesSettings.MAX_SHINGLE_SIZE * TimeSeriesSettings.SEASONALITY_TO_SHINGLE_RATIO),
871871
randomIntBetween(1, 1000),
872872
null,
@@ -1069,7 +1069,7 @@ public void testNullFixedValue() throws IOException {
10691069
TestHelpers.randomUser(),
10701070
null,
10711071
new ImputationOption(ImputationMethod.FIXED_VALUES, null),
1072-
randomIntBetween(1, 10000),
1072+
randomIntBetween(2, 10000),
10731073
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
10741074
randomIntBetween(1, 1000),
10751075
null,

‎src/test/java/org/opensearch/ad/rest/ADRestTestUtils.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ public static Response createAnomalyDetector(
220220
null,
221221
// we don't release imputation until 2.17. Disable it in bwc first.
222222
null, // TestHelpers.randomImputationOption(featureList),
223-
randomIntBetween(1, 10000),
223+
randomIntBetween(2, 10000),
224224
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
225225
randomIntBetween(1, 1000),
226226
null,

‎src/test/java/org/opensearch/ad/rest/AnomalyDetectorRestApiIT.java

+9-9
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ public void testCreateAnomalyDetectorWithDuplicateName() throws Exception {
167167
TestHelpers.randomUser(),
168168
null,
169169
TestHelpers.randomImputationOption(featureList),
170-
randomIntBetween(1, 10000),
170+
randomIntBetween(2, 10000),
171171
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
172172
randomIntBetween(1, 1000),
173173
null,
@@ -367,7 +367,7 @@ public void testUpdateAnomalyDetector_disableFlattenResultIndex_shouldDeletePipe
367367
detector.getUser(),
368368
detector.getCustomResultIndexOrAlias(),
369369
TestHelpers.randomImputationOption(features),
370-
randomIntBetween(1, 10000),
370+
randomIntBetween(2, 10000),
371371
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
372372
randomIntBetween(1, 1000),
373373
null,
@@ -434,7 +434,7 @@ public void testUpdateAnomalyDetectorFlattenResultIndexField() throws Exception
434434
detector.getUser(),
435435
detector.getCustomResultIndexOrAlias(),
436436
TestHelpers.randomImputationOption(features),
437-
randomIntBetween(1, 10000),
437+
randomIntBetween(2, 10000),
438438
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
439439
randomIntBetween(1, 1000),
440440
detector.getRules(),
@@ -563,7 +563,7 @@ public void testUpdateAnomalyDetectorCategoryField() throws Exception {
563563
detector.getUser(),
564564
null,
565565
TestHelpers.randomImputationOption(features),
566-
randomIntBetween(1, 10000),
566+
randomIntBetween(2, 10000),
567567
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
568568
randomIntBetween(1, 1000),
569569
null,
@@ -631,7 +631,7 @@ public void testUpdateAnomalyDetector() throws Exception {
631631
detector.getUser(),
632632
null,
633633
TestHelpers.randomImputationOption(features),
634-
randomIntBetween(1, 10000),
634+
randomIntBetween(2, 10000),
635635
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
636636
randomIntBetween(1, 1000),
637637
null,
@@ -704,7 +704,7 @@ public void testUpdateAnomalyDetectorNameToExisting() throws Exception {
704704
detector1.getUser(),
705705
null,
706706
TestHelpers.randomImputationOption(features),
707-
randomIntBetween(1, 10000),
707+
randomIntBetween(2, 10000),
708708
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
709709
randomIntBetween(1, 1000),
710710
null,
@@ -754,7 +754,7 @@ public void testUpdateAnomalyDetectorNameToNew() throws Exception {
754754
detector.getUser(),
755755
null,
756756
TestHelpers.randomImputationOption(features),
757-
randomIntBetween(1, 10000),
757+
randomIntBetween(2, 10000),
758758
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
759759
randomIntBetween(1, 1000),
760760
null,
@@ -810,7 +810,7 @@ public void testUpdateAnomalyDetectorWithNotExistingIndex() throws Exception {
810810
detector.getUser(),
811811
null,
812812
TestHelpers.randomImputationOption(features),
813-
randomIntBetween(1, 10000),
813+
randomIntBetween(2, 10000),
814814
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
815815
randomIntBetween(1, 1000),
816816
null,
@@ -1196,7 +1196,7 @@ public void testUpdateAnomalyDetectorWithRunningAdJob() throws Exception {
11961196
detector.getUser(),
11971197
null,
11981198
TestHelpers.randomImputationOption(features),
1199-
randomIntBetween(1, 10000),
1199+
randomIntBetween(2, 10000),
12001200
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
12011201
randomIntBetween(1, 1000),
12021202
null,

‎src/test/java/org/opensearch/ad/rest/HistoricalAnalysisRestApiIT.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ private AnomalyDetector randomAnomalyDetector(AnomalyDetector detector) {
343343
detector.getUser(),
344344
detector.getCustomResultIndexOrAlias(),
345345
detector.getImputationOption(),
346-
randomIntBetween(1, 10000),
346+
randomIntBetween(2, 10000),
347347
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
348348
randomIntBetween(1, 1000),
349349
null,

‎src/test/java/org/opensearch/ad/rest/SecureADRestIT.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ public void testUpdateApiFilterByEnabledForAdmin() throws IOException {
257257
),
258258
null,
259259
aliceDetector.getImputationOption(),
260-
randomIntBetween(1, 10000),
260+
randomIntBetween(2, 10000),
261261
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
262262
randomIntBetween(1, 1000),
263263
null,
@@ -313,7 +313,7 @@ public void testUpdateApiFilterByEnabled() throws IOException {
313313
),
314314
null,
315315
aliceDetector.getImputationOption(),
316-
randomIntBetween(1, 10000),
316+
randomIntBetween(2, 10000),
317317
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
318318
randomIntBetween(1, 1000),
319319
null,

‎src/test/java/org/opensearch/ad/transport/AnomalyResultTransportActionTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ private AnomalyDetector randomDetector(List<String> indices, List<Feature> featu
220220
null,
221221
null,
222222
TestHelpers.randomImputationOption(features),
223-
randomIntBetween(1, 10000),
223+
randomIntBetween(2, 10000),
224224
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
225225
randomIntBetween(1, 1000),
226226
null,
@@ -252,7 +252,7 @@ private AnomalyDetector randomHCDetector(List<String> indices, List<Feature> fea
252252
null,
253253
null,
254254
TestHelpers.randomImputationOption(features),
255-
randomIntBetween(1, 10000),
255+
randomIntBetween(2, 10000),
256256
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
257257
randomIntBetween(1, 1000),
258258
null,

‎src/test/java/org/opensearch/ad/transport/ForwardADTaskRequestTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public void testNullDetectorIdAndTaskAction() throws IOException {
7979
randomUser(),
8080
null,
8181
TestHelpers.randomImputationOption(null),
82-
randomIntBetween(1, 10000),
82+
randomIntBetween(2, 10000),
8383
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
8484
randomIntBetween(1, 1000),
8585
null,

‎src/test/java/org/opensearch/ad/transport/ValidateAnomalyDetectorTransportActionTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ public void testValidateAnomalyDetectorWithInvalidDetectorName() throws IOExcept
398398
TestHelpers.randomUser(),
399399
null,
400400
TestHelpers.randomImputationOption(featureList),
401-
randomIntBetween(1, 10000),
401+
randomIntBetween(2, 10000),
402402
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
403403
randomIntBetween(1, 1000),
404404
null,
@@ -448,7 +448,7 @@ public void testValidateAnomalyDetectorWithDetectorNameTooLong() throws IOExcept
448448
TestHelpers.randomUser(),
449449
null,
450450
TestHelpers.randomImputationOption(featureList),
451-
randomIntBetween(1, 10000),
451+
randomIntBetween(2, 10000),
452452
randomInt(TimeSeriesSettings.MAX_SHINGLE_SIZE / 2),
453453
randomIntBetween(1, 1000),
454454
null,

0 commit comments

Comments
 (0)