Skip to content

Commit e28ff14

Browse files
committed
addressing comments
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
1 parent 67f0a08 commit e28ff14

File tree

2 files changed

+12
-16
lines changed

2 files changed

+12
-16
lines changed

public/pages/main/Main.tsx

+10-14
Original file line numberDiff line numberDiff line change
@@ -65,28 +65,24 @@ export function Main(props: MainProps) {
6565
return `#${basePath}?${searchParams.toString()}`;
6666
};
6767

68-
// Usage examples:
69-
const dashboardHref = constructHrefWithDataSourceId(
70-
APP_PATH.DASHBOARD,
71-
'',
72-
dataSourceId
73-
);
74-
const overviewHref = constructHrefWithDataSourceId(
75-
APP_PATH.OVERVIEW,
76-
'',
77-
dataSourceId
78-
);
79-
8068
const sideNav = [
8169
{
8270
name: Navigation.AnomalyDetection,
8371
id: 0,
84-
href: overviewHref,
72+
href: constructHrefWithDataSourceId(
73+
APP_PATH.OVERVIEW,
74+
'',
75+
dataSourceId
76+
),
8577
items: [
8678
{
8779
name: Navigation.Dashboard,
8880
id: 1,
89-
href: dashboardHref,
81+
href: constructHrefWithDataSourceId(
82+
APP_PATH.DASHBOARD,
83+
'',
84+
dataSourceId
85+
),
9086
isSelected: props.location.pathname === APP_PATH.DASHBOARD,
9187
},
9288
{

public/pages/utils/helpers.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ export const getAllDetectorsQueryParamsWithDataSourceId = (
122122
size: MAX_DETECTORS,
123123
sortDirection: SORT_DIRECTION.ASC,
124124
sortField: 'name',
125-
dataSourceId: dataSourceId,
125+
dataSourceId
126126
});
127127

128128
export const getSampleDetectorsQueryParamsWithDataSouceId = (
@@ -134,5 +134,5 @@ export const getSampleDetectorsQueryParamsWithDataSouceId = (
134134
size: MAX_DETECTORS,
135135
sortDirection: SORT_DIRECTION.ASC,
136136
sortField: 'name',
137-
dataSourceId: dataSourceId,
137+
dataSourceId
138138
});

0 commit comments

Comments
 (0)