Skip to content

Commit a6fa630

Browse files
Remove unnecessary sleep between test runs (#746) (#754)
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <kaituo@amazon.com> (cherry picked from commit e509a03) Co-authored-by: Kaituo Li <kaituo@amazon.com>
1 parent 70d4183 commit a6fa630

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

.github/workflows/remote-integ-tests-workflow.yml

+6-11
Original file line numberDiff line numberDiff line change
@@ -140,21 +140,16 @@ jobs:
140140
- name: Finding spec files and store to output
141141
id: finding-files
142142
run: |
143-
echo "::set-output name=FILELIST::$(find cypress/integration/plugins/anomaly-detection-dashboards-plugin -name '*.js' -print)"
144-
working-directory: opensearch-dashboards-functional-test
145-
146-
- name: Print spec files from output
147-
run: |
148-
IFS="," read -a myarray <<< ${{ steps.finding-files.outputs.FILELIST }}
149-
for i in "${myarray[@]}"; do
150-
echo "${i}"
151-
done
143+
{
144+
echo 'FILELIST<<EOF'
145+
find cypress/integration/plugins/anomaly-detection-dashboards-plugin -name '*.js' -print
146+
echo EOF
147+
} >> "$GITHUB_ENV"
152148
working-directory: opensearch-dashboards-functional-test
153149

154150
- name: Run spec files from output
155151
run: |
156-
IFS="," read -a myarray <<< ${{ steps.finding-files.outputs.FILELIST }}
157-
for i in "${myarray[@]}"; do
152+
for i in $FILELIST; do
158153
yarn cypress:run-without-security --browser electron --spec "${i}"
159154
sleep 60
160155
done

0 commit comments

Comments
 (0)