Bump ZSTD lib to version 1.5.6-1. #17674
Conversation
Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
mulugetam
requested review from
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for a825f9f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@mulugetam there are few PR checks failing that might need a fix. |
Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
|
❌ Gradle check result for e38dc9a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
| @@ -78,7 +78,7 @@ bytebuddy = "1.15.10" | |||
| jmh = "1.35" | |||
|
|
|||
| # compression | |||
| zstd = "1.5.5-5" | |||
| zstd = "1.5.6-1" | |||
There was a problem hiding this comment.
@mulugetam we may need to update OpenSearch core in lockstep as well please, https://github.com/opensearch-project/OpenSearch/blob/main/gradle/libs.versions.toml#L81, thank you
There was a problem hiding this comment.
@reta Would you clarify? I didn’t quite get what you meant.
There was a problem hiding this comment.
@mulugetam my bad, I miscommented (was sure this is custom-codecs repo), all good, apologies
|
❌ Gradle check result for ae4068e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
|
❌ Gradle check result for b71646f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@reta One of the failures looks like a timeout, but I'm not sure what's going on with the other one. |
@mulugetam indeed, this is a new flaky tests https://build.ci.opensearch.org/job/gradle-check/54945/testReport/org.opensearch.plugin.kinesis/IngestFromKinesisIT/testKinesisIngestion_RewindByOffset/ :((( |
|
@reta @sarthakaggarwal97 When should we expect this to get merged? |
@mulugetam sure, could you please rebase and fix conflicts? thank you |
Description
Bumped up the ZSTD library to version 1.5.6-1. This version adds support for custom sequence producers, which makes it possible to add Intel® QAT-accelerated ZSTD in custom-codecs—on top of the existing
qat_deflateandqat_lz4. A similar PR is made for custom-codecs.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.