Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[segment replication] Increase the step size when replica promoting #17566

Open
guojialiang92 opened this issue Mar 11, 2025 · 0 comments · May be fixed by #17568
Open

[segment replication] Increase the step size when replica promoting #17566

guojialiang92 opened this issue Mar 11, 2025 · 0 comments · May be fixed by #17568
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep untriaged

Comments

@guojialiang92
Copy link

guojialiang92 commented Mar 11, 2025 •
edited
Loading

Is your feature request related to a problem? Please describe

4365 proposed a method to avoid segment file name conflicts when replica promoting (Increase segment counter by 10 when replica closes).
In the production environment, if GC hang occurs on the node where primary shard is located or the segment replication is not synchronized for a long time, it is still easy to have conflicts. And there is no way to make adjustments after a problem occurs.

Describe the solution you'd like

Can we add the dynamic configuration of the index level and increase the default value to 100000?
The segment counter is a value of type long and it is almost impossible to out of bound.

Related component

No response

Describe alternatives you've considered

No response

Additional context

No response
@guojialiang92 guojialiang92 added enhancement Enhancement or improvement to existing feature or request untriaged labels Mar 11, 2025
@guojialiang92 guojialiang92 linked a pull request Mar 11, 2025 that will close this issue
Open
3 tasks
@guojialiang92 guojialiang92 changed the title [segment replication] add SEGMENT_COUNTER_INCREMENT_STEP_SETTING and increase default step [segment replication] Increase the step size when replica promoting Mar 11, 2025
@andrross andrross added Indexing:Replication Issues and PRs related to core replication framework eg segrep and removed _No response_ labels Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep untriaged
Projects
None yet
Milestone
No milestone
2 participants
@andrross @guojialiang92