[BUG] listener.onFailure is not called on failure to pin the older timestamp

[sachinpkale]

Describe the bug

• Today, if we try to pin the timestamp that is older than now() - Lookbak Interval, we throw IllegalArgumentException
• But as RemoteStorePinnedTimestampService.pinTimestamp is async, on any failure, listener.onFailure() should be called.
  

  OpenSearch/server/src/main/java/org/opensearch/node/remotestore/RemoteStorePinnedTimestampService.java

  Lines 132 to 140 in acf209f

  	public void pinTimestamp(long timestamp, String pinningEntity, ActionListener<Void> listener) {
  	// If a caller uses current system time to pin the timestamp, following check will almost always fail.
  	// So, we allow pinning timestamp in the past upto some buffer
  	long lookbackIntervalInMills = RemoteStoreSettings.getPinnedTimestampsLookbackInterval().millis();
  	if (timestamp < (System.currentTimeMillis() - lookbackIntervalInMills)) {
  	throw new IllegalArgumentException(
  	"Timestamp to be pinned is less than current timestamp - value of cluster.remote_store.pinned_timestamps.lookback_interval"
  	);
  	}

• Due to this, caller will keep waiting on listener.

Related component

Storage:Remote

To Reproduce

• Create snapshot V2 repo.
• While creating V2 snapshot, add a sleep of 61 secs between fetching of timestamp to be pinned and actual pinTimestamp call.

Expected behavior

• On failure, listener.onFailure should be called.