[Feature Request] Remove LinearRing

[dblock]

Is your feature request related to a problem? Please describe

Coming from #12834 (comment) and #12324, LinearRing looks like dead code. The fix introduced in #12834 is to handle missing serialization in that type of data.

Describe the solution you'd like

1. Remove LinearRing and related code.
2. Close Implement serialization for LinearRing. #12831 without merging.
3. Revert Catch task description error #12834 and the backport for custom-handling the exception.

Related component

Search

Describe alternatives you've considered

• Implement Implement serialization for LinearRing. #12831.

Additional context

• Catch task description error #12834
• Implement serialization for LinearRing. #12831

[peternied]

[Triage - attendees 1 2 3 4 5 6]
@dblock Thanks for creating this issue, we'd welcome a pull request to address this

[andrross]

Adding on to my comment here: #12834 (comment)

I don't think LinearRing is truly dead code, as it is used by the Polygon class. My comment is that a LinearRing is just a type of a Line (which it does in fact extend) with some additional constraints (namely that the first and last points are the same). My assertion is that we may be able to get ride of the ShapeType.LINEARRING enum value, but keep the LinearRing class. It would be serializable like any other line and could just delegate to the parent methods. The LinearRing class would still provide enforcement of its additional constraint as well as type safety for the Polygon class to ensure the constituent components of a Polygon are in fact linear rings.