Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiered Caching] [Milestone 1] Added took time in QuerySearchResult object #10411

Closed
sgup432 opened this issue Oct 5, 2023 · 0 comments
Closed
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc

Comments

@sgup432
Copy link
Contributor

sgup432 commented Oct 5, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like

We need to determine query cost(in terms of latency) to put it on disk cache or not when item is evicted. As for queries(on shard level) which are already cheap enough, it doesn't make sense to cache it on disk. For that, we need to add this info in shard query result object. This way whenever we are taking a decision to put it to disk cache, we will consider to cache queries with took time > Xms.

Details - #10024
and #10870

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@sgup432 sgup432 added enhancement Enhancement or improvement to existing feature or request untriaged labels Oct 5, 2023
@sgup432 sgup432 moved this to In-Review in Performance Roadmap Nov 3, 2023
@ankitkala ankitkala added Search Search query, autocomplete ...etc and removed Other labels Dec 17, 2023
@macohen macohen removed the untriaged label Dec 20, 2023
@sgup432 sgup432 closed this as completed Jan 19, 2024
@github-project-automation github-project-automation bot moved this from In-Review to Done in Performance Roadmap Jan 19, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants