Skip to content

Commit e0c19a7

Browse files
committed
Fix permissions for test
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
1 parent b7d4ea5 commit e0c19a7

File tree

3 files changed

+37
-6
lines changed

3 files changed

+37
-6
lines changed

plugins/arrow-flight-rpc/src/test/java/org/opensearch/arrow/flight/FlightStreamPluginTests.java

+2-5
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public class FlightStreamPluginTests extends OpenSearchTestCase {
4242
@Override
4343
public void setUp() throws Exception {
4444
super.setUp();
45-
settings = Settings.builder().put("node.attr.transport.stream.port", "9880").put(ARROW_STREAMS_SETTING.getKey(), true).build();
45+
settings = Settings.builder().put(ARROW_STREAMS_SETTING.getKey(), true).build();
4646
clusterService = mock(ClusterService.class);
4747
ClusterState clusterState = mock(ClusterState.class);
4848
DiscoveryNodes nodes = mock(DiscoveryNodes.class);
@@ -53,10 +53,7 @@ public void setUp() throws Exception {
5353

5454
public void testPluginEnableAndDisable() throws IOException {
5555

56-
Settings disabledSettings = Settings.builder()
57-
.put("node.attr.transport.stream.port", "9880")
58-
.put(ARROW_STREAMS_SETTING.getKey(), false)
59-
.build();
56+
Settings disabledSettings = Settings.builder().put(ARROW_STREAMS_SETTING.getKey(), false).build();
6057
FeatureFlags.initializeFeatureFlags(disabledSettings);
6158
FlightStreamPlugin disabledPlugin = new FlightStreamPlugin(disabledSettings);
6259

plugins/arrow-flight-rpc/src/test/java/org/opensearch/arrow/flight/bootstrap/ServerConfigTests.java

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ public class ServerConfigTests extends OpenSearchTestCase {
2222
public void setUp() throws Exception {
2323
super.setUp();
2424
settings = Settings.builder()
25-
.put("node.attr.transport.stream.port", 9880)
2625
.put("arrow.allocation.manager.type", "Netty")
2726
.put("arrow.enable_null_check_for_get", false)
2827
.put("arrow.enable_unsafe_memory_access", true)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
/*
2+
* SPDX-License-Identifier: Apache-2.0
3+
*
4+
* The OpenSearch Contributors require contributions made to
5+
* this file be licensed under the Apache-2.0 license or a
6+
* compatible open source license.
7+
*/
8+
9+
grant codeBase "${codebase.grpc-netty-shaded}" {
10+
permission java.net.SocketPermission "*", "accept,connect,listen,resolve";
11+
permission java.lang.RuntimePermission "*", "setContextClassLoader";
12+
};
13+
14+
grant codeBase "${codebase.grpc-core}" {
15+
permission java.net.SocketPermission "*", "accept,connect,listen,resolve";
16+
permission java.lang.RuntimePermission "*", "setContextClassLoader";
17+
};
18+
19+
grant {
20+
// arrow flight service permissions
21+
permission java.util.PropertyPermission "arrow.allocation.manager.type", "write";
22+
permission java.util.PropertyPermission "arrow.enable_null_check_for_get", "write";
23+
permission java.util.PropertyPermission "arrow.enable_unsafe_memory_access", "write";
24+
permission java.util.PropertyPermission "arrow.memory.debug.allocator", "write";
25+
26+
permission java.util.PropertyPermission "io.netty.tryReflectionSetAccessible", "write";
27+
permission java.util.PropertyPermission "io.netty.allocator.numDirectArenas", "write";
28+
permission java.util.PropertyPermission "io.netty.noUnsafe", "write";
29+
permission java.util.PropertyPermission "io.netty.tryUnsafe", "write";
30+
31+
// Needed for netty based arrow flight server for netty configs related to buffer allocator
32+
permission java.security.AllPermission "modifyThreadGroup";
33+
permission java.lang.reflect.ReflectPermission "suppressAccessChecks";
34+
permission java.util.PropertyPermission "arrow.allocation.manager.type", "write";
35+
};

0 commit comments

Comments
 (0)