Skip to content

Commit dcb64d8

Browse files
authored
Make the gradle check comment more compact (#11151)
Continuing in the spirit of #9699, this makes the gradle check comment less verbose while containing all the same information. The goal is to reduce visual noise on the PR feed and maybe allow for more comments before GitHub starts hiding older comments behind the "load more" link. This is super subjective so happy to hear any opinions if the previous format is preferred. Signed-off-by: Andrew Ross <andrross@amazon.com>
1 parent 0d54c16 commit dcb64d8

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

.github/workflows/gradle-check.yml

+6-14
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,7 @@ jobs:
8282
with:
8383
issue-number: ${{ env.pr_number }}
8484
body: |
85-
### Gradle Check (Jenkins) Run Completed with:
86-
* **RESULT:** ${{ env.result }} :white_check_mark:
87-
* **URL:** ${{ env.workflow_url }}
88-
* **CommitID:** ${{ env.pr_from_sha }}
85+
:white_check_mark: Gradle check result for ${{ env.pr_from_sha }}: [${{ env.result }}](${{ env.workflow_url }})
8986
9087
- name: Extract Test Failure
9188
if: ${{ github.event_name == 'pull_request_target' && env.result != 'SUCCESS' }}
@@ -108,10 +105,8 @@ jobs:
108105
with:
109106
issue-number: ${{ env.pr_number }}
110107
body: |
111-
### Gradle Check (Jenkins) Run Completed with:
112-
* **RESULT:** ${{ env.result }} :grey_exclamation: ${{ env.test_failures }}
113-
* **URL:** ${{ env.workflow_url }}
114-
* **CommitID:** ${{ env.pr_from_sha }}
108+
:grey_exclamation: Gradle check result for ${{ env.pr_from_sha }}: [${{ env.result }}](${{ env.workflow_url }}) ${{ env.test_failures }}
109+
115110
Please review all [flaky tests](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) that succeeded after retry and create an issue if one does not already exist to track the flaky failure.
116111
117112
- name: Create Comment Failure
@@ -120,12 +115,9 @@ jobs:
120115
with:
121116
issue-number: ${{ env.pr_number }}
122117
body: |
123-
### Gradle Check (Jenkins) Run Completed with:
124-
* **RESULT:** ${{ env.result }} :x: ${{ env.test_failures }}
125-
* **URL:** ${{ env.workflow_url }}
126-
* **CommitID:** ${{ env.pr_from_sha }}
127-
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
128-
Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?
118+
:x: Gradle check result for ${{ env.pr_from_sha }}: [${{ env.result }}](${{ env.workflow_url }})
119+
120+
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?
129121
130122
- name: Create Issue On Push Failure
131123
if: ${{ github.event_name == 'push' && failure() }}

0 commit comments

Comments
 (0)