Skip to content

Commit d26cd46

Browse files
authored
TermsAggregatorTests flaky test fix (#13567)
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
1 parent 6ba6f59 commit d26cd46

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

server/src/test/java/org/opensearch/search/aggregations/bucket/terms/TermsAggregatorTests.java

+12-5
Original file line numberDiff line numberDiff line change
@@ -353,33 +353,40 @@ private void testSimple(
353353
newIndexWriterConfig().setMergePolicy(NoMergePolicy.INSTANCE)
354354
)
355355
) {
356+
List<Document> documents = new ArrayList<>();
356357
Document document = new Document();
357358
addFieldConsumer.apply(document, "string", "a");
358359
addFieldConsumer.apply(document, "string", "b");
359-
indexWriter.addDocument(document);
360+
documents.add(document);
361+
360362
document = new Document();
361363
addFieldConsumer.apply(document, "string", "");
362364
addFieldConsumer.apply(document, "string", "c");
363365
addFieldConsumer.apply(document, "string", "a");
364-
indexWriter.addDocument(document);
366+
documents.add(document);
367+
365368
document = new Document();
366369
addFieldConsumer.apply(document, "string", "b");
367370
addFieldConsumer.apply(document, "string", "d");
368-
indexWriter.addDocument(document);
371+
documents.add(document);
372+
369373
document = new Document();
370374
addFieldConsumer.apply(document, "string", "");
371375
if (includeDocCountField) {
372376
// Adding _doc_count to one document
373377
document.add(new NumericDocValuesField("_doc_count", 10));
374378
}
375-
indexWriter.addDocument(document);
379+
documents.add(document);
376380

377381
if (includeDeletedDocumentsInSegment) {
378382
document = new Document();
379383
ADD_SORTED_SET_FIELD_INDEXED.apply(document, "string", "e");
380-
indexWriter.addDocument(document);
384+
documents.add(document);
385+
indexWriter.addDocuments(documents);
381386
indexWriter.deleteDocuments(new Term("string", "e"));
382387
assertEquals(5, indexWriter.getDocStats().maxDoc); // deleted document still in segment
388+
} else {
389+
indexWriter.addDocuments(documents);
383390
}
384391

385392
try (IndexReader indexReader = maybeWrapReaderEs(indexWriter.getReader())) {

0 commit comments

Comments
 (0)