Skip to content

Commit 174344b

Browse files
committed
Move DefaultSecureTransportParameters to separate file and add javadoc
Signed-off-by: Craig Perkins <cwperx@amazon.com>
1 parent 937578c commit 174344b

File tree

2 files changed

+31
-14
lines changed

2 files changed

+31
-14
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
/*
2+
* SPDX-License-Identifier: Apache-2.0
3+
*
4+
* The OpenSearch Contributors require contributions made to
5+
* this file be licensed under the Apache-2.0 license or a
6+
* compatible open source license.
7+
*/
8+
9+
package org.opensearch.plugins;
10+
11+
import org.opensearch.common.network.NetworkModule;
12+
import org.opensearch.common.settings.Settings;
13+
14+
/**
15+
* Default implementation of {@link SecureTransportSettingsProvider.SecureTransportParameters}.
16+
*/
17+
class DefaultSecureTransportParameters implements SecureTransportSettingsProvider.SecureTransportParameters {
18+
private final Settings settings;
19+
20+
DefaultSecureTransportParameters(Settings settings) {
21+
this.settings = settings;
22+
}
23+
24+
@Override
25+
public boolean dualModeEnabled() {
26+
return NetworkModule.TRANSPORT_SSL_DUAL_MODE_ENABLED.get(settings);
27+
}
28+
}

server/src/main/java/org/opensearch/plugins/SecureTransportSettingsProvider.java

+3-14
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
package org.opensearch.plugins;
1010

1111
import org.opensearch.common.annotation.ExperimentalApi;
12-
import org.opensearch.common.network.NetworkModule;
1312
import org.opensearch.common.settings.Settings;
1413
import org.opensearch.transport.Transport;
1514
import org.opensearch.transport.TransportAdapterProvider;
@@ -47,24 +46,14 @@ default Optional<SecureTransportParameters> parameters(Settings settings) {
4746
return Optional.of(new DefaultSecureTransportParameters(settings));
4847
}
4948

49+
/**
50+
* Dynamic parameters that can be provided by the {@link SecureTransportSettingsProvider}
51+
*/
5052
@ExperimentalApi
5153
interface SecureTransportParameters {
5254
boolean dualModeEnabled();
5355
}
5456

55-
class DefaultSecureTransportParameters implements SecureTransportParameters {
56-
private final Settings settings;
57-
58-
DefaultSecureTransportParameters(Settings settings) {
59-
this.settings = settings;
60-
}
61-
62-
@Override
63-
public boolean dualModeEnabled() {
64-
return NetworkModule.TRANSPORT_SSL_DUAL_MODE_ENABLED.get(settings);
65-
}
66-
}
67-
6857
/**
6958
* If supported, builds the {@link TransportExceptionHandler} instance for {@link Transport} instance
7059
* @param settings settings

0 commit comments

Comments
 (0)