Skip to content

Commit dba41b4

Browse files
committedFeb 15, 2024
expose get function for other plugins to use
Signed-off-by: Tianle Huang <tianleh@amazon.com>
1 parent 7604899 commit dba41b4

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed
 

‎src/plugins/application_config/server/opensearch_config_client.ts

-2
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,4 @@ export class OpenSearchConfigurationClient implements ConfigurationClient {
5353
throw e;
5454
}
5555
}
56-
57-
5856
}

‎src/plugins/application_config/server/plugin.ts

+6-4
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,12 @@ export class ApplicationConfigPlugin
3838
this.configurationIndexName = '';
3939
}
4040

41-
private setConfigurationClient(inputConfigurationClient: ConfigurationClient) {
41+
private registerConfigurationClient(inputConfigurationClient: ConfigurationClient) {
42+
this.logger.info('Register a configuration client.');
4243
this.configurationClient = inputConfigurationClient;
4344
}
4445

45-
private getConfigurationClient(inputOpenSearchClient: IScopedClusterClient) {
46+
private getConfigurationClient(inputOpenSearchClient: IScopedClusterClient): ConfigurationClient {
4647
if (this.configurationClient) {
4748
return this.configurationClient;
4849
}
@@ -68,7 +69,8 @@ export class ApplicationConfigPlugin
6869
defineRoutes(router, this.getConfigurationClient.bind(this), this.logger);
6970

7071
return {
71-
setConfigurationClient: this.setConfigurationClient.bind(this),
72+
getConfigurationClient: this.getConfigurationClient.bind(this),
73+
registerConfigurationClient: this.registerConfigurationClient.bind(this),
7274
};
7375
}
7476

@@ -77,5 +79,5 @@ export class ApplicationConfigPlugin
7779
return {};
7880
}
7981

80-
public stop() { }
82+
public stop() {}
8183
}

‎src/plugins/application_config/server/types.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1+
import { IScopedClusterClient } from 'src/core/server';
2+
13
export interface ApplicationConfigPluginSetup {
2-
setConfigurationClient: (inputConfigurationClient: ConfigurationClient) => void;
4+
getConfigurationClient: (inputOpenSearchClient: IScopedClusterClient) => ConfigurationClient;
5+
registerConfigurationClient: (inputConfigurationClient: ConfigurationClient) => void;
36
}
47
// eslint-disable-next-line @typescript-eslint/no-empty-interface
5-
export interface ApplicationConfigPluginStart { }
8+
export interface ApplicationConfigPluginStart {}
69

710
export interface ConfigurationClient {
811
getConfig(): Promise<string>;

0 commit comments

Comments
 (0)