-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edX to Open edX App Data Migration Path #99
Comments
Hey @marcotuts , @volodymyr-chekyrta considering the current implementation for the Android app, applying branding to the existing code can be achieved using native approaches. Our app currently supports two themes: LightMode and DarkMode. To accommodate multiple branding options, we can create various themes within the app and configure the following properties to match the desired theme:
We have the flexibility to define as many themes as necessary and create a Dark Mode variant accordingly. To provide a clear visual representation of the app after the rebranding process, we have updated the color scheme, fonts, and image resources following the approach mentioned above.
|
Pasting iOS team's findings here as well. Multiple colors and imagesApp main colors and images are being used from the assets of the Core framework. At the moment, it will be a bit hard for someone to directly replace the colors of the app in the assets because maintaining the change set will require extra effort as it contains data for other images and icons. And some colors, like white, are hardcoded in the codebase. Some images have a tinted color as well, like, for example, blue for the back arrow that is being used in the navbar. It will make changing a theme a bit harder and will require icon/image changes as well. Recommendation: The images that are being used in the navbar or bottom bar shouldn’t have any tinted color and the main theme color should be applied while using the icon so it matches the main theme color. FontsAlthough fonts are being used through the theme class, and the parsing of fonts is also being done in the theme class. A code-level change (theme class parsing update) will be required to use different fonts. Recommendation: Icons and splash screenThe asset folder of the target Recommendation: |
Update: Axinite will work to incorporate the recommendations in the app. Tickets for this work to be created soon. FYI: @touchapp @marcotuts @volodymyr-chekyrta @miankhalid please review the findings and share feedback. We can also discuss this in our Technical Check-in call on Monday. |
At this point it seems some tickets / improvements are coming in relating to this work - Is there an edx app build that could eventually be shared out with some of the wg-mobile team members once it exists? It would be helpful to be able to see a built via testflight or whenever ready as a contrast with the existing open edx app to do a live comparison in the themes but also to compare against the edX app (once ready - don't know how close we are to this - @moiz994 |
@marcotuts currently, we're just implementing the ability to update the theme of the app easily. We will work on the edX them of the app a little later in time but be happy to share that once it is ready. |
Any update here on how close we think we are on this data migration / theme push? |
@miankhalid & @touchapp can share more details on the data migration. |
This may be close to ready to mark complete? The testflight build and theme customization seem done but will keep this epic open until we have confirmed this is ok to close. |
@marcotuts yes, theme is almost done. It's finalized on iOS but now Android team needs to implement what was finalized on iOS. Also, I still don't know what is the way forward in terms of the data migration. @miankhalid @touchapp need your help and updates on this. |
@miankhalid @moiz994 @marcotuts Following are my findings on the data migration from edX to open edX Android:
iOS:
Note: I have also created the issue for this which is mentioned above |
With the findings above, are we ok to close this epic out @miankhalid / @moiz994 ? Or keep open a bit longer until the findings are explored / reviewed? |
* chore: add video and discussion analytics (#93) * fix: fixes after merge, deleted IAP parts * chore: changed dependency version, deleted unused analytics part * chore: regenerate mocks * chore: In app ratings modal and profile picture picture sheet UI improvements (#94) * chore: show subtitles for videos in full-screen mode (#97) * fix: after merge * fix: iOS 18 Toggle tap gesture (#98) * fix: added priority for toggle tap gesture * fix: fixed tap and drag actions for Toggle --------- Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com> * fix: gesture for ios 18.2 * chore: quick fix with performance for subtitles view * chore: sign-in and register screens social sign in improvements (#95) * chore: fix after merge * fix: fix microsoft login issue on iOS after config branch merges (#96) * refactor: change the microsoft key name in the script (#101) * chore: fix access modifier * chore: re-generate nocks * chore: hide grades when sub section dependents not available (#99) * chore: fix after merge * chore: hide progress points from assignment status (#100) * chore: fix test --------- Co-authored-by: Saeed Bashir <sbashir@2u.com> Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com> Co-authored-by: Shafqat Muneer <smuneer@2u.com>
Goal:
edX mobile team to get a working internal build of the new open edx mobile applications to confirm feature gap list scope, theming capabilities, data migration needs, and more.
Potential scope draft:
Outcomes:
....
Step 1 - Devop Alignment
Tasks
The text was updated successfully, but these errors were encountered: