Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Pre-Login Mobile App Exploration #109

Open
1 of 5 tasks
marcotuts opened this issue Oct 12, 2023 · 8 comments
Open
1 of 5 tasks

[iOS] Pre-Login Mobile App Exploration #109

marcotuts opened this issue Oct 12, 2023 · 8 comments
Assignees
Labels
epic Large unit of work, consisting of multiple tasks

Comments

@marcotuts
Copy link

marcotuts commented Oct 12, 2023

Candidate for edX / 2U ownership given existing knowledge

Tasks

Preview Give feedback
  1. saeedbashir
  2. saeedbashir
@marcotuts marcotuts self-assigned this Oct 12, 2023
@marcotuts marcotuts converted this from a draft issue Oct 12, 2023
@marcotuts
Copy link
Author

Candidate for edX product + design definition

@marcotuts marcotuts added the epic Large unit of work, consisting of multiple tasks label Oct 12, 2023
@marcotuts marcotuts removed their assignment Oct 19, 2023
@marcotuts marcotuts moved this from Prioritized Backlog to Extended Backlog / Icebox in Open edX Mobile Roadmap Oct 23, 2023
@marcotuts marcotuts moved this from Extended Backlog / Icebox to In Development in Open edX Mobile Roadmap Oct 24, 2023
@marcotuts
Copy link
Author

Updated development start / end dates (just estimates for now fyi @miankhalid , @moiz994

@miankhalid
Copy link

PRs for both platforms are up but we can't seem to link them with this issue, any idea how we can link?

links for the PRs:

  1. feat: pre-login mobile app exploration #139
  2. feat: pre-login mobile app exploration openedx-app-android#86

@moiz994 moiz994 moved this from In Development to In Code Review / Final Acceptance in Open edX Mobile Roadmap Nov 13, 2023
@marcotuts marcotuts changed the title Pre-Login Mobile App Exploration [Mobile] [iOS] Pre-Login Mobile App Exploration [iOS] Nov 15, 2023
@marcotuts
Copy link
Author

Thanks for flagging @miankhalid , I will connect these asap if I can.

@nizmaylova nizmaylova changed the title Pre-Login Mobile App Exploration [iOS] [iOS] Pre-Login Mobile App Exploration Nov 16, 2023
@miankhalid miankhalid moved this from In Code Review / Final Acceptance to Done in Open edX Mobile Roadmap Dec 5, 2023
@marcotuts
Copy link
Author

The PRs were merged as is but I'm not clear if additional work here is planned - FYI @miankhalid , @volodymyr-chekyrta , @moiz994 - Anything we should document re: turnign this on, or suggestions for additional work that should go into this epic before we close?

This isn't potentially defaulted to true / enabled by default, should we discuss whether this should be defaulted on / off? Other items to review potentially includes documentation for this?

@moiz994
Copy link

moiz994 commented Dec 8, 2023

I think we can follow the current pattern about whether it is on by default or not (@miankhalid, please let me know which one is true). But having documentation would be good.
I'll test it out and finalize if there's any other work that needs to be added to this epic before we can close it.

@moiz994 moiz994 moved this from Done to In Development in Open edX Mobile Roadmap Dec 11, 2023
@moiz994
Copy link

moiz994 commented Dec 11, 2023

[iOS] Enrolment button handling in non-logged-in experience#197 needs to be linked to this epic.

@touchapp touchapp linked a pull request Jan 16, 2024 that will close this issue
@marcotuts
Copy link
Author

@moiz994 - I'm hoping to review an up to date build of the app soon, but from your perspective has all the work necessary here moved to done / acceptance?

In particular the documentation approach might be still tbd here, or clear within the code at least for now, but other than that (which might need a longer conversation cross-projects and its own roadmap entry), perhaps this is ready to close?

@marcotuts marcotuts moved this from In Development to In Code Review / Final Acceptance in Open edX Mobile Roadmap Feb 6, 2024
@moiz994 moiz994 moved this from In Code Review / Final Acceptance to Done in Open edX Mobile Roadmap Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Large unit of work, consisting of multiple tasks
Projects
Status: Done
Development

No branches or pull requests

5 participants