Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to main v2.1 #421

Merged
merged 10 commits into from
Feb 11, 2025
Merged

Develop to main v2.1 #421

merged 10 commits into from
Feb 11, 2025

Conversation

volodymyr-chekyrta
Copy link
Contributor

Sync develop to the main branch.

Features:

  • Static Code Analyzer:
    Introduced Detekt for static analysis and applied several refactorings (e.g., reducing nested block depth and other rule changes) to address warnings.
  • Browser-Based Authentication:
    Added support for login and registration via a browser custom tab, enabling third-party authentication flows.

Fixes:

  • Course & Unit Handling:
    • Fixed the issue with dataValue for CourseOutline.
    • Addressed problems handling units with no descendants and prevented a crash when retrieving the first topic.
  • Transcription & Analytics:
    • Caught exceptions during transcription file parsing.
    • Improved analytics event tracking and added missing events.
  • Bulk Download & Offline Mode:
    • Fixed a crash during bulk downloads by validating progress values (fixing LEARNER-10248).
    • Resolved issues with opening courses in offline mode.

Chores & Refactors:

  • Video Playback & Network Handling:
    Enabled auto-play for videos when ready and handled the “no network” error for Webview.
  • Static Analyzer Refactoring:
    Made additional minor rule changes and code adjustments as part of the static analyzer integration.

PavloNetrebchuk and others added 10 commits November 15, 2024 11:06
* feat: detekt

* refactor: Changes according to detekt warnings

* refactor: Address NestedBlockDepth warnings by reducing block nesting

* refactor: Changes according to detekt warnings

* refactor: minor rule changes
Co-authored-by: Hamza Israr <71447999+HamzaIsrar12@users.noreply.github.com>
* feat: Support for login and registration via a browser custom tab

This change adds support for logging in and registering a new account using the
browser. This can be useful for cases where the only way to log into the
instatance is via a custom third-party auth provider.

* fixup! feat: Support for login and registration via a browser custom tab
- Add validation to ensure that the progress value is not NaN.

fixes: LEARNER-10248

Co-authored-by: Farhan Arshad <43750646+farhan-arshad-dev@users.noreply.github.com>
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 10, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @volodymyr-chekyrta!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@volodymyr-chekyrta volodymyr-chekyrta merged commit 66e9a79 into main Feb 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants