-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop to main v2.1 #421
Develop to main v2.1 #421
Conversation
* feat: detekt * refactor: Changes according to detekt warnings * refactor: Address NestedBlockDepth warnings by reducing block nesting * refactor: Changes according to detekt warnings * refactor: minor rule changes
Co-authored-by: Hamza Israr <71447999+HamzaIsrar12@users.noreply.github.com>
* feat: Support for login and registration via a browser custom tab This change adds support for logging in and registering a new account using the browser. This can be useful for cases where the only way to log into the instatance is via a custom third-party auth provider. * fixup! feat: Support for login and registration via a browser custom tab
- Add validation to ensure that the progress value is not NaN. fixes: LEARNER-10248 Co-authored-by: Farhan Arshad <43750646+farhan-arshad-dev@users.noreply.github.com>
Thanks for the pull request, @volodymyr-chekyrta! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Sync develop to the main branch.
Features:
Introduced Detekt for static analysis and applied several refactorings (e.g., reducing nested block depth and other rule changes) to address warnings.
Added support for login and registration via a browser custom tab, enabling third-party authentication flows.
Fixes:
Chores & Refactors:
Enabled auto-play for videos when ready and handled the “no network” error for Webview.
Made additional minor rule changes and code adjustments as part of the static analyzer integration.