-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make redux
and react-redux
optional peer dependencies
#766
Comments
See #763, which includes a fix for this issue. Note it uses the following: {
"peerDependenciesMeta": {
"redux": {
"optional": true
},
"react-redux": {
"optional": true
}
}
} instead of |
The changes in #763 ended up breaking tests on consuming MFEs due to the async Next steps:
|
[inform] Opened a new standalone PR for this contribution: #768 |
Currently, frontend-platform requires MFEs to install
redux
andreact-redux
even if the MFE doesn't use Redux. frontend-platform renders anOptionalReduxProvider
component, where if nostore
prop is passed to<AppProvider>
within the MFE, Redux'sProvider
is not rendered.However, for MFEs that opt to NOT use Redux (e.g.,
frontend-app-learner-portal-enterprise
), these peer dependencies are still required to install, even though they're not used.Ideally, frontend-platform could denote these peer dependencies as being optional, handling it accordingly when the package is not installed.
The text was updated successfully, but these errors were encountered: