-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video editor supports transcripts (minimal version) #1352
Comments
@jmakowski1123 @ormsbee What's the priority of this relative to the list of bugs we have? Should we do a minimal version of this as a bugfix? e.g. "ensure transcripts continue working when a video component is pasted into a library". |
My take on it is that we leave Video transcripts in its not-so-great state for Sumac and focus on other bugs. I'd like to take some more time to examine how to take a (backwards compatible) flamethrower through a lot of the existing transcripts code rather than trying to stuff 1:1-ish parity into Sumac. |
Taking a flamethrower to the transcripts code sounds like a great plan to me. |
Does the flamethrower approach mean transcripts won't work in pasted content? |
@jmakowski1123: I believe there are three or four different ways to specify transcripts today, they get auto-converted between three internal formats, and there are hard-coded, VideoBlock-level assumptions about where those transcripts live. Some of those work today (two where transcripts are listed explicitly via edxval or in the block itself, but using only the SRT file format). I think this is the most common way to specify transcripts now. But the oldest convention that assumes SRT files are in the root files and uploads directory probably won't work, srt.json files won't work. etc. Even describing the compatibility matrix is complex because this code is that crazy. I think we'll want to do some sort of data transformation to convert this into the most modern format rather than supporting the matrix of previous formats. We might even use this chance to switchover to VTT, which we've wanted to do for years. But that needs time and planning to work out. |
Got it. We can get away with no transcript support for Sumac, as long as we message it. I created a ticket to change the text (or remove the field entirely) for now. #1453 |
@jmakowski1123 I edited the requirements for this ticket. Can you please review it? ^ |
@jmakowski1123 @sdaitzman @edschema This is ready for AC testing on the sandbox. Also, we identified this issues: #1688 You can also check them. |
Thanks @ChrisChV, taking a look at this. Is there a test file or test video component already added that I should test with? (Happy to generate a video and .srt transcript if needed too) |
@sdaitzman Yes, you can test it from the creation of the video using this video link to add it in the Video URL field: https://www.sample-videos.com/video321/mp4/720/big_buck_bunny_720p_2mb.mp4 You can add new transcripts. You can use this str files. You can test the download transcript from YouTube using this video link to add it in the Video URL field: https://youtu.be/dGby9BH9bMc |
One additional note: the transcript does appear alongside the video when copy and pasting from the library into a unit, but not when adding the video via the "Library Content" button. |
These errors occur only in the sandbox. CC @bradenmacdonald (1) The transcripts are being saved in the static assets, but an error occurs when downloading them, which is why the transcripts are not displayed. @bradenmacdonald Do you have any idea what could be happening?
(2) The get_transcript_link_from_youtube function, which obtains the information from the transcripts by requesting YouTube, is failing. The problem is that it looks for it within the response, but it seems that YouTube detects that the request comes from a server and returns a different response without the transcripts (locally it does work well). |
@ChrisChV It looks like the sandbox might be mis-configured somehow? Because it's trying to load the file from disk, but all the Learning Core static assets should be saved in S3. Actually, now that I look, all the images we've previously uploaded seem to be missing as well. I think a recent change on our sandbox staging environment has affected the static assets (by removing the S3 config). I will ask the team what's happening. |
@ChrisChV Yep, an unrelated change to our sandbox deployments is the root cause here. See BB-9336 for details. It should be resolved in a day or so. |
Trying to test this one again: Currently, when I add a transcript to a video within a course, it appears alongside the content as expected. The video is then able to be copied into a library as expected. However, when I try to use the library video block with transcript within a course, I'm getting an error. I'll assume the fix on the unrelated issue @bradenmacdonald mentioned is not yet complete. Will loop back on a later day. ![]() |
This ticket is for bare-minimum transcript support in video components:
Note what this excludes: if you create a non-Youtube video in a library, it may not be possible to upload a transcript manually via the editor. Though if that's easy to implement it would be a nice improvement to include.
The text was updated successfully, but these errors were encountered: