Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On a live instance of Open edX, make sure that all calls go to v2 (and are consistent with v1 responses) #47

Closed
regisb opened this issue Aug 18, 2024 · 1 comment · Fixed by #83
Closed

On a live instance of Open edX, make sure that all calls go to v2 (and are consistent with v1 responses) #47

regisb opened this issue Aug 18, 2024 · 1 comment · Fixed by #83
Assignees
@Faraz32123

Comments

@regisb
Copy link
Contributor

regisb commented Aug 18, 2024 •
edited
Loading

Once all views have been migrated, we should verify that no calls to v2 are transferred to v1. We can achieve that by logging an error each time a request is forwarded from v2 to v1.

In addition, we should verify that GET requests are consistent with v1 responses; we can do that thanks to #4.

Testing should be performed manually on an actual (test) instance of Open edX, covering all possible use cases.
@Faraz32123 Faraz32123 self-assigned this Sep 5, 2024
@Faraz32123 Faraz32123 mentioned this issue Sep 5, 2024
Merged
@Faraz32123
Copy link
Contributor

  • response of get thread API varies when thread type is question and it was varying according to query params.
  • response of get thread API varies when thread type is question and we endorse and un-endorse it.
  • response for user's subscribed threads was also different as it wasn't deleting subscriptions of the threads on deleting the thread.

Will make a PR for above v1/v2 differences.

Faraz32123 pushed a commit that referenced this issue Sep 10, 2024
fix: differences in forum v1 and v2 get responses
afd8a7c 
- fix the response of get thread API according to query params
when thread type is question
- fix the response of get thread API when answered question is marked
back as not answered when thread type is question.
- fix the response of user's subscribed thread API as it wasn't deleting
the subscriptions of the thread when thread was deleted, and was returning
more subscribed threads in the response
- add tests for the above cases
- close #47
@Faraz32123 Faraz32123 mentioned this issue Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Faraz32123 Faraz32123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: differences in forum v1 and v2 get responses openedx/forum
2 participants
@regisb @Faraz32123