-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: large text for rating #70
Conversation
Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 5 5
Lines 226 226
=======================================
Hits 209 209
Misses 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi there @ziafazal! I put you here as reviewer due to you have reviewed some pr's from edunext, could you take a look over here please? Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnvente Thanks for creating PR with improved styling. I have couple of suggestions if you can look into those it would be great.
Hi @ziafazal I addressed one of your suggestion please let me know if is okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@feanil: could you help us merge this PR? Thanks! |
Hi @farhan! Could you help us review/merge this? Thanks! |
I won't be able to review this in a week so I will check any changes 1 April |
@johnvente |
2c8f6ff
to
4126ab6
Compare
@farhan: Jhon won't be available until April 1st, so I rebased this instead. Could you check again? Thanks! |
@johnvente 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds a small fix for when the rating text is too long for the options and increases the 'Number of ratings' to provide more space for feedback in the instructor tab.
BEFORE - RATING
NOW - RATING
BEFORE - INSTRUCTOR TAB
NOW -INSTRUCTOR TAB
How to test it
From Studio, in your course >
Advanced Settings
>Advanced Module List
> add "feedback" in the list.In a new unit add a feedback component
Edit the component and put a long text for each
Likert option
save and check if the rating are in row