Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: large text for rating #70

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

johnvente
Copy link
Contributor

@johnvente johnvente commented Mar 18, 2024

Description

This PR adds a small fix for when the rating text is too long for the options and increases the 'Number of ratings' to provide more space for feedback in the instructor tab.

BEFORE - RATING

Screen Shot 2024-03-18 at 6 43 09 PM

NOW - RATING

Screen Shot 2024-03-18 at 6 42 50 PM

BEFORE - INSTRUCTOR TAB

Screen Shot 2024-03-18 at 6 43 09 PM

NOW -INSTRUCTOR TAB

Screen Shot 2024-03-18 at 6 42 50 PM

How to test it

  1. Check this branch inside the XBlock
 git fetch origin pull/70/head:jv/fix-feedback-ui-problems
 git checkoutjv/fix-feedback-ui-problems
  1. In your environment add the following setting as doc
name: feedback-xblock-settings
version: 0.1.0
patches:
  openedx-common-settings: |
    FEATURES["ENABLE_FEEDBACK_INSTRUCTOR_VIEW"] = True
    OPEN_EDX_FILTERS_CONFIG = {
      "org.openedx.learning.instructor.dashboard.render.started.v1": {
        "fail_silently": False,
        "pipeline": [
          "feedback.extensions.filters.AddFeedbackTab",
        ]
      },
    }
  1. From Studio, in your course > Advanced Settings > Advanced Module List > add "feedback" in the list.

  2. In a new unit add a feedback component

  3. Edit the component and put a long text for each Likert option save and check if the rating are in row

@openedx-webhooks
Copy link

Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (ae9ef41) to head (4126ab6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files           5        5           
  Lines         226      226           
=======================================
  Hits          209      209           
  Misses         17       17           
Flag Coverage Δ
unittests 92.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnvente johnvente requested a review from ziafazal March 19, 2024 13:55
@johnvente
Copy link
Contributor Author

johnvente commented Mar 19, 2024

Hi there @ziafazal! I put you here as reviewer due to you have reviewed some pr's from edunext, could you take a look over here please? Thanks a lot!

Copy link

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnvente Thanks for creating PR with improved styling. I have couple of suggestions if you can look into those it would be great.

@johnvente
Copy link
Contributor Author

Hi @ziafazal I addressed one of your suggestion please let me know if is okay

Copy link

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mariajgrimaldi
Copy link
Member

@feanil: could you help us merge this PR? Thanks!

@johnvente johnvente requested a review from feanil March 21, 2024 15:01
@mariajgrimaldi
Copy link
Member

Hi @farhan! Could you help us review/merge this? Thanks!

@mariajgrimaldi mariajgrimaldi requested a review from farhan March 22, 2024 15:03
@johnvente
Copy link
Contributor Author

I won't be able to review this in a week so I will check any changes 1 April

@farhan
Copy link
Contributor

farhan commented Mar 23, 2024

@johnvente
Thanks for the work. Please rebase and resolve conflicts

@mariajgrimaldi mariajgrimaldi force-pushed the jv/fix-feedback-ui-problems branch from 2c8f6ff to 4126ab6 Compare March 25, 2024 15:34
@mariajgrimaldi
Copy link
Member

@farhan: Jhon won't be available until April 1st, so I rebased this instead. Could you check again? Thanks!

@farhan farhan merged commit cb3c38d into openedx:master Mar 26, 2024
8 checks passed
@openedx-webhooks
Copy link

@johnvente 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants