Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance for start and stop points for Http Server span/duration metric #2005

Open
tylerbenson opened this issue Mar 18, 2025 · 1 comment

Comments

@tylerbenson
Copy link
Member

Area(s)

area:http

What's missing?

In the client span spec, there's some guidance on when the span should start/stop, and the expectation that the duration metric roughly follows.
Similar guidance is missing on the Http Server side of the spec.

Describe the solution you'd like

I'd like to see clarification on when the span/metric should be started and stopped. Starting is a bit more obvious and intuitive (as soon as the request headers are parsed that the http server framework allows), but the end is less clear. Most comprehensive would be when the last response body byte is sent, but I have seen arguments for after the headers are committed and before the response body is sent. (Perhaps the specification should instead add that point as a span event.)

@trask
Copy link
Member

trask commented Mar 19, 2025

adding slack comment from @jsuereth:

I think the "generic" http server span should represent the entire time taken to process the request (from parsing to last byte)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Need triage
Development

No branches or pull requests

2 participants