Skip to content

Commit de25ecb

Browse files
authored
[editorial] Move supplementary-guidelines into docs (#1284)
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
1 parent c22cd95 commit de25ecb

File tree

13 files changed

+46
-12
lines changed

13 files changed

+46
-12
lines changed

docs/README.md

+2
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,5 @@ Semantic Conventions by signals:
4242
* [Metrics](general/metrics.md): Semantic Conventions for metrics.
4343
* [Resource](resource/README.md): Semantic Conventions for resources.
4444
* [Trace](general/trace.md): Semantic Conventions for traces and spans.
45+
46+
Also see, [Non-normative supplementary information](non-normative/README.md).

docs/cloud-providers/aws-sdk.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Some descriptions are also provided for populating general OpenTelemetry semanti
1515

1616
## Context Propagation
1717

18-
See [compatibility](../../supplementary-guidelines/compatibility/aws.md#context-propagation).
18+
See [compatibility](../non-normative/compatibility/aws.md#context-propagation).
1919

2020
## Common Attributes
2121

docs/faas/aws-lambda.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ For every message in the event, the [message system attributes][] (not message a
168168
the user) SHOULD be checked for the key `AWSTraceHeader`. If it is present, an OpenTelemetry `Context` SHOULD be
169169
parsed from the value of the attribute using the [AWS X-Ray Propagator](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.33.0/specification/context/api-propagators.md) and
170170
added as a link to the span. This means the span may have as many links as messages in the batch.
171-
See [compatibility](../../supplementary-guidelines/compatibility/aws.md#context-propagation) for more info.
171+
See [compatibility](../non-normative/compatibility/aws.md#context-propagation) for more info.
172172

173173
- [`faas.trigger`][faas] MUST be set to `pubsub`.
174174
- [`messaging.operation.type`](/docs/messaging/messaging-spans.md) MUST be set to `process`.
@@ -181,7 +181,7 @@ corresponding to the SQS event. The [message system attributes][] (not message a
181181
the user) SHOULD be checked for the key `AWSTraceHeader`. If it is present, an OpenTelemetry `Context` SHOULD be
182182
parsed from the value of the attribute using the [AWS X-Ray Propagator](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.33.0/specification/context/api-propagators.md) and
183183
added as a link to the span.
184-
See [compatibility](../../supplementary-guidelines/compatibility/aws.md#context-propagation) for more info.
184+
See [compatibility](../non-normative/compatibility/aws.md#context-propagation) for more info.
185185

186186
- [`faas.trigger`][faas] MUST be set to `pubsub`.
187187
- [`messaging.operation.type`](/docs/messaging/messaging-spans.md#messaging-attributes) MUST be set to `process`.

docs/general/attributes.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<!--- Hugo front matter used to generate the website version of this page:
22
linkTitle: Attributes
3-
aliases: [docs/specs/semconv/general/general-attributes]
3+
aliases: [general-attributes]
44
--->
55

66
# General Attributes

docs/general/events.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<!--- Hugo front matter used to generate the website version of this page:
22
linkTitle: Events
3-
aliases: [docs/specs/semconv/general/events-general]
3+
aliases: [events-general]
44
--->
55

66
# Semantic Conventions for Events

docs/general/logs.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<!--- Hugo front matter used to generate the website version of this page:
22
linkTitle: Logs
3-
aliases: [docs/specs/semconv/general/logs-general]
3+
aliases: [logs-general]
44
--->
55

66
# General Logs Attributes

docs/general/metrics.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<!--- Hugo front matter used to generate the website version of this page:
22
linkTitle: Metrics
3-
aliases: [docs/specs/semconv/general/metrics-general]
3+
aliases: [metrics-general]
44
--->
55

66
# Metrics Semantic Conventions

docs/non-normative/README.md

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<!--- Hugo front matter used to generate the website version of this page:
2+
linkTitle: Non-normative
3+
path_base_for_github_subdir:
4+
from: tmp/semconv/docs/non-normative/_index.md
5+
to: non-normative/README.md
6+
--->
7+
8+
# Non-normative supplementary information
9+
10+
The pages in this section are **non-normative**, most are supplementary
11+
guidelines.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<!--- Hugo front matter used to generate the website version of this page:
2+
path_base_for_github_subdir:
3+
from: tmp/semconv/docs/non-normative/compatibility/_index.md
4+
to: non-normative/compatibility/README.md
5+
--->
6+
7+
# Compatibility

supplementary-guidelines/compatibility/aws.md docs/non-normative/compatibility/aws.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1+
<!--- Hugo front matter used to generate the website version of this page:
2+
linkTitle: AWS
3+
--->
4+
15
# Compatibility Considerations for AWS
26

3-
This document highlights compatibility considerations for OpenTelemetry
7+
This page highlights compatibility considerations for OpenTelemetry
48
instrumentations when interacting with AWS managed services using an aws-sdk,
59
a third-party library, or a direct HTTP request.
610

docs/http/migration-guide.md docs/non-normative/http-migration.md

+7-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
# HTTP semantic convention stability migration guide
1+
<!--- Hugo front matter used to generate the website version of this page:
2+
linkTitle: HTTP migration
3+
aliases: [../http/migration-guide]
4+
--->
5+
6+
# HTTP semantic convention stability migration
27

38
Due to the significant number of modifications and the extensive user base
49
affected by them, existing HTTP instrumentations published by
@@ -207,7 +212,7 @@ which case `{summary}` is `HTTP`.
207212

208213
### Migrating from `<= v1.16.0`
209214

210-
This document does not cover these versions.
215+
This page does not cover these versions.
211216

212217
[Host header]: https://tools.ietf.org/html/rfc7230#section-5.4
213218
[HTTP/2 authority]: https://tools.ietf.org/html/rfc9113#section-8.3.1

supplementary-guidelines/semantic_conventions_code_generation.md docs/non-normative/libraries.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
<!--- Hugo front matter used to generate the website version of this page:
2+
linkTitle: Libraries
3+
# Renamed from: semantic_conventions_code_generation
4+
--->
5+
16
# Semantic convention libraries
27

38
<!-- toc -->
@@ -115,4 +120,4 @@ Code-generation usually involves several steps which could be semi-automated:
115120
5. Fix lint violations in the auto-generated code (if any)
116121
6. Send the PR with new code to the corresponding repository
117122

118-
Here're the examples of how steps 2-5 are implemented for [Java](https://github.com/open-telemetry/semantic-conventions-java/blob/7da24068eea69dff11a78d59750b115dc4c5854d/build.gradle.kts#L55-L137) and [Python](https://github.com/open-telemetry/opentelemetry-python/blob/397e357dfad3e6ff42c09c74d5945dfdcad24bdd/scripts/semconv/generate.sh).
123+
Here are examples of how steps 2-5 are implemented for [Java](https://github.com/open-telemetry/semantic-conventions-java/blob/7da24068eea69dff11a78d59750b115dc4c5854d/build.gradle.kts#L55-L137) and [Python](https://github.com/open-telemetry/opentelemetry-python/blob/397e357dfad3e6ff42c09c74d5945dfdcad24bdd/scripts/semconv/generate.sh).

internal/tools/update_specification_version.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ fix_file() {
2727
"$1"
2828
}
2929

30-
important_files=("docs" "model" "README.md" "supplementary-guidelines")
30+
important_files=("docs" "model" "README.md")
3131

3232
# TODO - limit to markdown/yaml files?
3333
find "${important_files[@]}" -type f -not -path '*/.*' -print0 | while read -d $'\0' file; do

0 commit comments

Comments
 (0)