-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post: 2024 in review #5775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! First round of comments, see inline. 🙏
I think that it might be better to organize this blog as follows. After the introductory paragraph, the top-level sections should be the following:
Move current sections as subsection of these top-level sections, as appropriate. |
94377f5
to
18e262c
Compare
I also think that we should have a section "For authoring contributors" and in there mention "new" tools or techniques or existing ones that have increased in use, such as code-excerpt functionality. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this post, @svrnm! I can't believe how quickly you pulled it all together. It's fantastic! I touched up the wording, but otherwise looks great to me!
Let me see if/how I can restructure it.
That's a good one, let me think about that one as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the co-authorship 🙏. The suggestions below fix the build, so let me merge the suggested changes and we can work from there.
Btw, how best can we collaborate on finalizing this post?
7f45ae4
to
97114b4
Compare
a5623a0
to
765091c
Compare
I've marked this as Draft, as I work on the reorg (as we agreed on Slack). |
87b16fd
to
ff3ea4f
Compare
cf12080
to
f19b68c
Compare
/easycla is stuck, but otherwise, call checks are currently green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny fixes...LGTM!
@tiffany76 - thank you for the careful review and catching those. I've accepted all of your suggestions. |
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
b40a57f
to
645d2b2
Compare
Signed-off-by: svrnm <neumanns@cisco.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com> Co-authored-by: Patrice Chalin <pchalin@gmail.com>
As discussed on Monday during the SIG call here is a draft for a year in review blog post for SIG Comms