Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Flag PR branches named main #5639

Open
chalin opened this issue Nov 19, 2024 · 2 comments
Open

[CI] Flag PR branches named main #5639

chalin opened this issue Nov 19, 2024 · 2 comments
Labels
CI/infra CI & infrastructure e0-minutes Effort: < 60 min enhancement New feature or request

Comments

@chalin
Copy link
Contributor

chalin commented Nov 19, 2024

Originally posted by @chalin in #5607 (review):

As documented in https://opentelemetry.io/docs/contributing/pull-requests/#pr-guidelines:

  • Do not work from the main branch of your fork, but create a PR-specific
    branch.

I'm not sure that you can rename the branch bound to a Github PR, or if it is worth it. I'll let @theletterf and you decide @Victorsesan.

@chalin
Copy link
Contributor Author

chalin commented Mar 1, 2025

From #6388:

Our contribution guidelines ask that PRs be submitted with a branch name other than main. I'd like to suggest that we add a simple GH PR check to report this when the PR is first submitted. Otherwise, we maintainers often only find out when it's "too late", i.e., we've gone through rounds of reviews, and want to submit a fix (either via our /fix commands or manually), but can't. WDYT @open-telemetry/docs-approvers?

@chalin chalin changed the title [CI] Add test to flag PRs from main branches of forks [CI] Flag PR branches named main Mar 17, 2025
@chalin
Copy link
Contributor Author

chalin commented Mar 17, 2025

PR in support of this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure e0-minutes Effort: < 60 min enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant