2
2
title : Pull request checks
3
3
description : Learn how to make your pull request successfully pass all checks
4
4
weight : 40
5
- cSpell:ignore : REFCACHE
6
5
---
7
6
8
7
When you raise a
9
8
[ pull request] ( https://docs.github.com/en/get-started/learning-about-github/github-glossary#pull-request )
10
9
(PR) with the
11
10
[ opentelemetry.io repository] ( https://github.com/open-telemetry/opentelemetry.io )
12
- a set of checks are executed. The PR checks verify that...
11
+ a set of checks are executed. The PR checks verify that:
13
12
14
- - … you have signed the [ CLA] ( #easy-cla ) .
15
- - …your commit can be deployed through [ Netlify] ( #netlify-deployment )
16
- successfully.
17
- - … your changes are compliant with our [ style guide] ( #style-checks ) .
13
+ - You have signed the [ CLA] ( #easy-cla )
14
+ - Your PR successfully [ deploys through Netlify] ( #netlify-deployment )
15
+ - Your changes are compliant with our [ style guide] ( #style-checks )
18
16
19
17
{{% alert title="Note" color="primary" %}}
20
18
21
19
If any of the PR checks fails, try to
22
- [ fix content issues automatically ] ( ../pull-requests/#fix-issues ) first by
23
- running ` npm run fix:all ` on your machine .
20
+ [ fix content issues] ( ../pull-requests/#fix-issues ) first by running
21
+ ` npm run fix:all ` locally .
24
22
25
- Additionally, you can comment ` /fix:all ` on your Pull Request . This will make
26
- the OpenTelemetry Bot run those commands on your behalf and update the PR. Make
23
+ You can also add the comment ` /fix:all ` to your PR . This will trigger the
24
+ OpenTelemetry Bot to run that command on your behalf and update the PR. Make
27
25
sure that you pull those changes locally.
28
26
29
27
Only if your issues persist, read below what the different checks do and how you
30
28
can recover from a failed state.
31
29
32
30
{{% /alert %}}
33
31
34
- ## Easy CLA
32
+ ## ` Easy CLA ` {.notranslate lang=en}
35
33
36
34
This check fails if you haven't [ signed the CLA] ( ../prerequisites/#cla ) .
37
35
@@ -49,7 +47,7 @@ find any issues.
49
47
The following list describes current checks and what you can do to fix related
50
48
errors:
51
49
52
- ### TEXT linter
50
+ ### ` TEXT linter ` {.notranslate lang=en}
53
51
54
52
This check verifies that
55
53
[ OpenTelemetry-specific terms and words are used consistently across the site] ( ../style-guide/#opentelemetryio-word-list ) .
@@ -59,51 +57,51 @@ If any issues are found, annotations are added to your files in the
59
57
alternative, you can run ` npm run check:text -- --fix ` locally to fix most
60
58
issues. Run ` npm run check:text ` again and manually fix the remaining issues.
61
59
62
- ### MARKDOWN linter
60
+ ### ` MARKDOWN linter ` {.notranslate lang=en}
63
61
64
62
This check verifies that
65
63
[ standards and consistency for Markdown files are enforced] ( ../style-guide/#markdown-standards ) .
66
64
67
- If any issues are found, run ` npm run:format ` to fix most issues. For more
65
+ If any issues are found, run ` npm run fix :format ` to fix most issues. For more
68
66
complex issues, run ` npm run check:markdown ` and apply the suggested changes.
69
67
70
- ### SPELLING check
68
+ ### ` SPELLING check ` {.notranslate lang=en}
71
69
72
70
This check verifies that
73
71
[ all words are spelled correctly] ( ../style-guide/#spell-checking ) .
74
72
75
- ### CSPELL: IGNORE check
73
+ ### ` CSPELL ` check {.notranslate lang=en}
76
74
77
75
This check will verify that all words in your cSpell ignore list are normalized.
78
76
79
77
If this check fails, run ` npm run fix:dict ` locally and push the changes in a
80
78
new commit.
81
79
82
- ### FILENAME check
80
+ ### ` FILENAME check ` {.notranslate lang=en}
83
81
84
82
This check verifies that all
85
83
[ files are formatted by prettier] ( ../style-guide/#file-format ) .
86
84
87
- If this check fails, run ` npm fix:format ` locally and push the changes in a new
88
- commit.
85
+ If this check fails, run ` npm run fix:format ` locally and push the changes in a
86
+ new commit.
89
87
90
- ### FILE FORMAT
88
+ ### ` FILE FORMAT ` {.notranslate lang=en}
91
89
92
90
This check verifies that all
93
91
[ file names are in kebab-case] ( ../style-guide/#file-names ) .
94
92
95
- If this check fails, run ` npm fix:filenames ` locally and push the changes in a
96
- new commit.
93
+ If this check fails, run ` npm run fix:filenames ` locally and push the changes in
94
+ a new commit.
97
95
98
- ### BUILD and CHECK LINKS / REFCACHE updates?
96
+ ### ` BUILD and CHECK LINKS ` {.notranslate lang=en}
99
97
100
- This check verifies that all links that your commits are introducing are
101
- functional.
98
+ This check builds the website and verifies that all links are valid.
102
99
103
- Run ` npm run check:links ` to check them locally . This also updates the reference
104
- cache, or ` REFCACHE ` . Push any changes to the ` REFCACHE ` in a new commit.
100
+ To check links locally, run ` npm run check:links ` . This command also updates the
101
+ reference cache . Push any changes to the refcache in a new commit.
105
102
106
- ### WARNINGS in build log?
103
+ ### ` WARNINGS in build log? ` {.notranslate lang=en}
107
104
108
- If this check fails, review the build log for any other potential issues. Ask
109
- maintainers for help, if you are unsure how to recover.
105
+ If this check fails, review the ` BUILD and CHECK LINKS ` log, under the
106
+ ` npm run log:check:links ` step, for any other potential issues. Ask maintainers
107
+ for help, if you are unsure how to recover.
0 commit comments