Skip to content

Commit adf1731

Browse files
authored
[i18n] Introduce notranslate convention and guidance (#6595)
1 parent 0369108 commit adf1731

File tree

2 files changed

+32
-31
lines changed

2 files changed

+32
-31
lines changed

content/en/docs/contributing/localization.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ guidance offered in this section.
2525
- **Translate**:
2626
- Page content, including:
2727
- Mermaid [diagram](#images) text fields
28-
- Code comments from code excerpts
28+
- Code comments from code excerpts (optional)
2929
- [Front matter][] field values for `title`, `linkTitle`, and `description`
3030
- **All** page content and front matter unless indicated otherwise
3131
- **Preserve** the _content_, _meaning_, and _style_ of the original text
@@ -45,6 +45,9 @@ guidance offered in this section.
4545
- **Translate**:
4646
- **File or directory** names of resources in this repository
4747
- [Links](#links), this includes [heading IDs](#headings).[^*]
48+
- Inline code-spans like these: `inline code example`
49+
- Markdown elements marked as `notranslate` (usually as a CSS class), in
50+
particular for [headings](#headings)
4851
- [Front matter][] fields other than those listed in [Do](#do). In particular,
4952
do not translate `aliases`. When in doubt, ask maintainers.
5053
- Code

content/en/docs/contributing/pr-checks.md

+28-30
Original file line numberDiff line numberDiff line change
@@ -2,36 +2,34 @@
22
title: Pull request checks
33
description: Learn how to make your pull request successfully pass all checks
44
weight: 40
5-
cSpell:ignore: REFCACHE
65
---
76

87
When you raise a
98
[pull request](https://docs.github.com/en/get-started/learning-about-github/github-glossary#pull-request)
109
(PR) with the
1110
[opentelemetry.io repository](https://github.com/open-telemetry/opentelemetry.io)
12-
a set of checks are executed. The PR checks verify that...
11+
a set of checks are executed. The PR checks verify that:
1312

14-
- … you have signed the [CLA](#easy-cla).
15-
- …your commit can be deployed through [Netlify](#netlify-deployment)
16-
successfully.
17-
- … your changes are compliant with our [style guide](#style-checks).
13+
- You have signed the [CLA](#easy-cla)
14+
- Your PR successfully [deploys through Netlify](#netlify-deployment)
15+
- Your changes are compliant with our [style guide](#style-checks)
1816

1917
{{% alert title="Note" color="primary" %}}
2018

2119
If any of the PR checks fails, try to
22-
[fix content issues automatically](../pull-requests/#fix-issues) first by
23-
running `npm run fix:all` on your machine.
20+
[fix content issues](../pull-requests/#fix-issues) first by running
21+
`npm run fix:all` locally.
2422

25-
Additionally, you can comment `/fix:all` on your Pull Request. This will make
26-
the OpenTelemetry Bot run those commands on your behalf and update the PR. Make
23+
You can also add the comment `/fix:all` to your PR. This will trigger the
24+
OpenTelemetry Bot to run that command on your behalf and update the PR. Make
2725
sure that you pull those changes locally.
2826

2927
Only if your issues persist, read below what the different checks do and how you
3028
can recover from a failed state.
3129

3230
{{% /alert %}}
3331

34-
## Easy CLA
32+
## `Easy CLA` {.notranslate lang=en}
3533

3634
This check fails if you haven't [signed the CLA](../prerequisites/#cla).
3735

@@ -49,7 +47,7 @@ find any issues.
4947
The following list describes current checks and what you can do to fix related
5048
errors:
5149

52-
### TEXT linter
50+
### `TEXT linter` {.notranslate lang=en}
5351

5452
This check verifies that
5553
[OpenTelemetry-specific terms and words are used consistently across the site](../style-guide/#opentelemetryio-word-list).
@@ -59,51 +57,51 @@ If any issues are found, annotations are added to your files in the
5957
alternative, you can run `npm run check:text -- --fix` locally to fix most
6058
issues. Run `npm run check:text` again and manually fix the remaining issues.
6159

62-
### MARKDOWN linter
60+
### `MARKDOWN linter` {.notranslate lang=en}
6361

6462
This check verifies that
6563
[standards and consistency for Markdown files are enforced](../style-guide/#markdown-standards).
6664

67-
If any issues are found, run `npm run:format` to fix most issues. For more
65+
If any issues are found, run `npm run fix:format` to fix most issues. For more
6866
complex issues, run `npm run check:markdown` and apply the suggested changes.
6967

70-
### SPELLING check
68+
### `SPELLING check` {.notranslate lang=en}
7169

7270
This check verifies that
7371
[all words are spelled correctly](../style-guide/#spell-checking).
7472

75-
### CSPELL:IGNORE check
73+
### `CSPELL` check {.notranslate lang=en}
7674

7775
This check will verify that all words in your cSpell ignore list are normalized.
7876

7977
If this check fails, run `npm run fix:dict` locally and push the changes in a
8078
new commit.
8179

82-
### FILENAME check
80+
### `FILENAME check` {.notranslate lang=en}
8381

8482
This check verifies that all
8583
[files are formatted by prettier](../style-guide/#file-format).
8684

87-
If this check fails, run `npm fix:format` locally and push the changes in a new
88-
commit.
85+
If this check fails, run `npm run fix:format` locally and push the changes in a
86+
new commit.
8987

90-
### FILE FORMAT
88+
### `FILE FORMAT` {.notranslate lang=en}
9189

9290
This check verifies that all
9391
[file names are in kebab-case](../style-guide/#file-names).
9492

95-
If this check fails, run `npm fix:filenames` locally and push the changes in a
96-
new commit.
93+
If this check fails, run `npm run fix:filenames` locally and push the changes in
94+
a new commit.
9795

98-
### BUILD and CHECK LINKS / REFCACHE updates?
96+
### `BUILD and CHECK LINKS` {.notranslate lang=en}
9997

100-
This check verifies that all links that your commits are introducing are
101-
functional.
98+
This check builds the website and verifies that all links are valid.
10299

103-
Run `npm run check:links` to check them locally. This also updates the reference
104-
cache, or `REFCACHE`. Push any changes to the `REFCACHE` in a new commit.
100+
To check links locally, run `npm run check:links`. This command also updates the
101+
reference cache. Push any changes to the refcache in a new commit.
105102

106-
### WARNINGS in build log?
103+
### `WARNINGS in build log?` {.notranslate lang=en}
107104

108-
If this check fails, review the build log for any other potential issues. Ask
109-
maintainers for help, if you are unsure how to recover.
105+
If this check fails, review the `BUILD and CHECK LINKS` log, under the
106+
`npm run log:check:links` step, for any other potential issues. Ask maintainers
107+
for help, if you are unsure how to recover.

0 commit comments

Comments
 (0)