From 34093a96552c128dbab5ab45677f9d0e6dfeb434 Mon Sep 17 00:00:00 2001 From: Matthew Boddewyn <31598686+mattbodd@users.noreply.github.com> Date: Tue, 13 Feb 2024 08:53:21 +0000 Subject: [PATCH 1/2] Ignore flaky opentelemetry-jaeger tests --- .../src/exporter/config/collector/http_client.rs | 1 + opentelemetry-jaeger/src/exporter/config/collector/mod.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/opentelemetry-jaeger/src/exporter/config/collector/http_client.rs b/opentelemetry-jaeger/src/exporter/config/collector/http_client.rs index 7cfa65dcf7..e88cd890e8 100644 --- a/opentelemetry-jaeger/src/exporter/config/collector/http_client.rs +++ b/opentelemetry-jaeger/src/exporter/config/collector/http_client.rs @@ -188,6 +188,7 @@ mod collector_client_tests { use opentelemetry::trace::TraceError; use opentelemetry_sdk::runtime::Tokio; + #[ignore] #[test] fn test_bring_your_own_client() -> Result<(), TraceError> { let invalid_uri_builder = new_collector_pipeline() diff --git a/opentelemetry-jaeger/src/exporter/config/collector/mod.rs b/opentelemetry-jaeger/src/exporter/config/collector/mod.rs index f97ba931a5..bb7690af56 100644 --- a/opentelemetry-jaeger/src/exporter/config/collector/mod.rs +++ b/opentelemetry-jaeger/src/exporter/config/collector/mod.rs @@ -571,6 +571,7 @@ mod tests { assert!(valid_uri.is_ok()); } + #[ignore] #[test] fn test_collector_exporter() { let exporter = new_collector_pipeline() From 6d7c8bf7b0c56a07521d84cf50e46281ca2502dd Mon Sep 17 00:00:00 2001 From: Matthew Boddewyn <31598686+mattbodd@users.noreply.github.com> Date: Wed, 14 Feb 2024 16:24:39 +0000 Subject: [PATCH 2/2] Leave comment to indicate why tests are ignored --- .../src/exporter/config/collector/http_client.rs | 1 + opentelemetry-jaeger/src/exporter/config/collector/mod.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/opentelemetry-jaeger/src/exporter/config/collector/http_client.rs b/opentelemetry-jaeger/src/exporter/config/collector/http_client.rs index e88cd890e8..14b84e7f09 100644 --- a/opentelemetry-jaeger/src/exporter/config/collector/http_client.rs +++ b/opentelemetry-jaeger/src/exporter/config/collector/http_client.rs @@ -188,6 +188,7 @@ mod collector_client_tests { use opentelemetry::trace::TraceError; use opentelemetry_sdk::runtime::Tokio; + // Ignore this test as it is flaky and the opentelemetry-jaeger is on-track for deprecation #[ignore] #[test] fn test_bring_your_own_client() -> Result<(), TraceError> { diff --git a/opentelemetry-jaeger/src/exporter/config/collector/mod.rs b/opentelemetry-jaeger/src/exporter/config/collector/mod.rs index bb7690af56..676720b1fb 100644 --- a/opentelemetry-jaeger/src/exporter/config/collector/mod.rs +++ b/opentelemetry-jaeger/src/exporter/config/collector/mod.rs @@ -571,6 +571,7 @@ mod tests { assert!(valid_uri.is_ok()); } + // Ignore this test as it is flaky and the opentelemetry-jaeger is on-track for deprecation #[ignore] #[test] fn test_collector_exporter() {