Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/Export concepts leaked into API. #1042

Closed
cijothomas opened this issue Apr 25, 2023 · 3 comments · Fixed by #2266
Closed

SDK/Export concepts leaked into API. #1042

cijothomas opened this issue Apr 25, 2023 · 3 comments · Fixed by #2266
Labels
A-common Area:common issues that not related to specific pillar release:required-for-stable Must be resolved before GA release, or nice to have before GA.
Milestone
0.27

Comments

@cijothomas
Copy link
Member

cijothomas commented Apr 25, 2023 •
edited
Loading

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/common.rs#L426
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/logs/mod.rs#L27
The above are part of Public API of the OpenTelemetry-API create. Its about "Export" which is an SDK only concept.
Wondering if this is intentional or accidental? If it is not intentional, we should move them into SDK befoe 1.0 stable.

(There are few other similar issues, will open separate issues to track them)
@cijothomas cijothomas mentioned this issue Apr 25, 2023
Open
@cijothomas cijothomas changed the title SDK concepts leaked into API. SDK/Export concepts leaked into API. Apr 25, 2023
@cijothomas cijothomas mentioned this issue Apr 25, 2023
Merged
@TommyCpp TommyCpp added A-trace Area: issues related to tracing release:required-for-stable Must be resolved before GA release, or nice to have before GA. labels May 1, 2023
@cijothomas cijothomas mentioned this issue Aug 11, 2023
Closed
@cijothomas cijothomas added this to the Tracing API And SDK Stable milestone Oct 17, 2023
@mladedav mladedav mentioned this issue Feb 15, 2024
Closed
This was referenced May 13, 2024
Merged
Open
@cijothomas
Copy link
Member Author

See additional comment to be fixed while resolving this issue:#1750 (comment)

@cijothomas cijothomas added A-common Area:common issues that not related to specific pillar and removed A-trace Area: issues related to tracing labels May 13, 2024
@cijothomas cijothomas mentioned this issue May 14, 2024
Open
@cijothomas
Copy link
Member Author

@lalitb Can you address for logs while fixing #2175 ? error handler is the reason for this issue, so would be good to close them together.

@lalitb
Copy link
Member

lalitb commented Oct 4, 2024

@lalitb Can you address for logs while fixing #2175 ? error handler is the reason for this issue, so would be good to close them together.

Yes.

@cijothomas cijothomas modified the milestones: Tracing API Stable, 0.27 Oct 7, 2024
@cijothomas cijothomas mentioned this issue Oct 10, 2024
Merged
4 tasks
@cijothomas cijothomas mentioned this issue Oct 25, 2024
Merged
4 tasks
This was referenced Oct 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-common Area:common issues that not related to specific pillar release:required-for-stable Must be resolved before GA release, or nice to have before GA.
Projects
None yet
Milestone
0.27
Development

Successfully merging a pull request may close this issue.

Move Logs and Metrics error constructs to SDK lalitb/opentelemetry-rust
4 participants
@hdost @lalitb @cijothomas @TommyCpp