Skip to content

Commit ed1d128

Browse files
rogercollTommyCpp
andauthored
test: wrap default batch test with temp_env (#1653)
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
1 parent 04a800c commit ed1d128

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

opentelemetry-sdk/src/trace/span_processor.rs

+15-2
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,8 @@ mod tests {
674674
new_test_export_span_data, new_tokio_test_exporter, InMemorySpanExporterBuilder,
675675
};
676676
use crate::trace::span_processor::{
677-
OTEL_BSP_EXPORT_TIMEOUT_DEFAULT, OTEL_BSP_MAX_EXPORT_BATCH_SIZE_DEFAULT,
677+
OTEL_BSP_EXPORT_TIMEOUT_DEFAULT, OTEL_BSP_MAX_CONCURRENT_EXPORTS,
678+
OTEL_BSP_MAX_CONCURRENT_EXPORTS_DEFAULT, OTEL_BSP_MAX_EXPORT_BATCH_SIZE_DEFAULT,
678679
};
679680
use crate::trace::{BatchConfig, BatchConfigBuilder, SpanEvents, SpanLinks};
680681
use async_trait::async_trait;
@@ -745,8 +746,20 @@ mod tests {
745746

746747
#[test]
747748
fn test_default_batch_config_adheres_to_specification() {
748-
let config = BatchConfig::default();
749+
let env_vars = vec![
750+
OTEL_BSP_SCHEDULE_DELAY,
751+
OTEL_BSP_EXPORT_TIMEOUT,
752+
OTEL_BSP_MAX_QUEUE_SIZE,
753+
OTEL_BSP_MAX_EXPORT_BATCH_SIZE,
754+
OTEL_BSP_MAX_CONCURRENT_EXPORTS,
755+
];
749756

757+
let config = temp_env::with_vars_unset(env_vars, BatchConfig::default);
758+
759+
assert_eq!(
760+
config.max_concurrent_exports,
761+
OTEL_BSP_MAX_CONCURRENT_EXPORTS_DEFAULT
762+
);
750763
assert_eq!(
751764
config.scheduled_delay,
752765
Duration::from_millis(OTEL_BSP_SCHEDULE_DELAY_DEFAULT)

0 commit comments

Comments
 (0)