Skip to content

Commit eaa1ce3

Browse files
authored
Merge branch 'main' into set-resource-status
2 parents 6f0a628 + 0303a38 commit eaa1ce3

File tree

6 files changed

+32
-6
lines changed

6 files changed

+32
-6
lines changed

examples/logs-basic/src/main.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ fn main() {
1313
// Ok(serde_json::to_writer_pretty(writer, &data).unwrap()))
1414
.build();
1515
let logger_provider = LoggerProvider::builder()
16-
.with_resource(Resource::new(vec![KeyValue::new(
16+
.with_resource(Resource::new([KeyValue::new(
1717
SERVICE_NAME,
1818
"logs-basic-example",
1919
)]))

examples/metrics-advanced/src/main.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ fn init_meter_provider() -> opentelemetry_sdk::metrics::SdkMeterProvider {
5252
let reader = PeriodicReader::builder(exporter, runtime::Tokio).build();
5353
let provider = SdkMeterProvider::builder()
5454
.with_reader(reader)
55-
.with_resource(Resource::new(vec![KeyValue::new(
55+
.with_resource(Resource::new([KeyValue::new(
5656
"service.name",
5757
"metrics-advanced-example",
5858
)]))

examples/metrics-basic/src/main.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ fn init_meter_provider() -> opentelemetry_sdk::metrics::SdkMeterProvider {
1313
let reader = PeriodicReader::builder(exporter, runtime::Tokio).build();
1414
let provider = SdkMeterProvider::builder()
1515
.with_reader(reader)
16-
.with_resource(Resource::new(vec![KeyValue::new(
16+
.with_resource(Resource::new([KeyValue::new(
1717
"service.name",
1818
"metrics-basic-example",
1919
)]))

opentelemetry-appender-tracing/Cargo.toml

+3
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ tracing-log = "0.2"
2727
async-trait = { workspace = true }
2828
criterion = { workspace = true }
2929

30+
[target.'cfg(not(target_os = "windows"))'.dev-dependencies]
31+
pprof = { version = "0.13", features = ["flamegraph", "criterion"] }
32+
3033
[features]
3134
experimental_metadata_attributes = ["dep:tracing-log"]
3235
logs_level_enabled = ["opentelemetry/logs_level_enabled"]

opentelemetry-appender-tracing/benches/logs.rs

+13-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ use opentelemetry_appender_tracing::layer as tracing_layer;
2121
use opentelemetry_sdk::export::logs::{LogData, LogExporter};
2222
use opentelemetry_sdk::logs::{LogProcessor, LoggerProvider};
2323
use opentelemetry_sdk::Resource;
24+
use pprof::criterion::{Output, PProfProfiler};
2425
use tracing::error;
2526
use tracing_subscriber::prelude::*;
2627
use tracing_subscriber::Layer;
@@ -173,5 +174,16 @@ fn criterion_benchmark(c: &mut Criterion) {
173174
benchmark_with_noop_layer(c, false, "noop_layer_disabled");
174175
}
175176

176-
criterion_group!(benches, criterion_benchmark);
177+
#[cfg(not(target_os = "windows"))]
178+
criterion_group! {
179+
name = benches;
180+
config = Criterion::default().with_profiler(PProfProfiler::new(100, Output::Flamegraph(None)));
181+
targets = criterion_benchmark
182+
}
183+
#[cfg(target_os = "windows")]
184+
criterion_group! {
185+
name = benches;
186+
config = Criterion::default();
187+
targets = criterion_benchmark
188+
}
177189
criterion_main!(benches);

opentelemetry-sdk/benches/metric_counter.rs

+13-2
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ use opentelemetry::{
1818
KeyValue,
1919
};
2020
use opentelemetry_sdk::metrics::{ManualReader, SdkMeterProvider};
21+
use pprof::criterion::{Output, PProfProfiler};
2122
use rand::{
2223
rngs::{self},
2324
Rng, SeedableRng,
@@ -155,6 +156,16 @@ fn counter_add(c: &mut Criterion) {
155156
});
156157
}
157158

158-
criterion_group!(benches, criterion_benchmark);
159-
159+
#[cfg(not(target_os = "windows"))]
160+
criterion_group! {
161+
name = benches;
162+
config = Criterion::default().with_profiler(PProfProfiler::new(100, Output::Flamegraph(None)));
163+
targets = criterion_benchmark
164+
}
165+
#[cfg(target_os = "windows")]
166+
criterion_group! {
167+
name = benches;
168+
config = Criterion::default();
169+
targets = criterion_benchmark
170+
}
160171
criterion_main!(benches);

0 commit comments

Comments
 (0)