Skip to content

Commit da9707a

Browse files
committed
doc
1 parent 72de6a4 commit da9707a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

opentelemetry-sdk/src/testing/logs/in_memory_exporter.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,11 @@ impl LogExporter for InMemoryLogsExporter {
178178
async fn export<'a>(&mut self, batch: Vec<Cow<'a, LogData>>) -> LogResult<()> {
179179
let mut logs_guard = self.logs.lock().map_err(LogError::from)?;
180180
for log in batch.into_iter() {
181-
logs_guard.push((*log).clone());
181+
logs_guard.push(log.to_owned());
182182
}
183183
Ok(())
184184
}
185+
185186
fn shutdown(&mut self) {
186187
if self.should_reset_on_shutdown {
187188
self.reset();

opentelemetry-stdout/src/logs/exporter.rs

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ impl opentelemetry_sdk::export::logs::LogExporter for LogExporter {
4747
/// Export spans to stdout
4848
async fn export<'a>(&mut self, batch: Vec<Cow<'a, LogData>>) -> ExportResult {
4949
if let Some(writer) = &mut self.writer {
50+
// TODO - Avoid cloning logdata if it is borrowed.
5051
let log_data = crate::logs::transform::LogData::from((
5152
batch.into_iter().map(Cow::into_owned).collect(),
5253
&self.resource,

0 commit comments

Comments
 (0)