Skip to content

Commit c5e1e14

Browse files
committed
update comments
1 parent 12b00eb commit c5e1e14

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

opentelemetry-sdk/src/trace/sampler/jaeger_remote/sampler.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ impl JaegerRemoteSampler {
206206
Err(err_msg) => {
207207
otel_warn!(
208208
name: "JaegerRemoteSampler.UpdateStrategy.RequestFailed",
209-
message = "Failed to fetch the new sampling strategy from remote endpoint. This may cause the sampler to use stale configuration until the next successful update.",
209+
message: "Failed to fetch the sampling strategy from the remote endpoint. The last successfully fetched configuration will be used if available; otherwise, the default sampler will be applied until a successful configuration fetch.",
210210
reason = format!("{}", err_msg),
211211
);
212212
}

opentelemetry-sdk/src/trace/sampler/jaeger_remote/sampling_strategy.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,9 @@ impl Inner {
107107
}
108108
})
109109
.unwrap_or_else(|_err| {
110-
otel_debug!(
110+
otel_warn!(
111111
name: "JaegerRemoteSampler.MutexPoisoned",
112-
message = "Unable to update Jaeger Remote sampling strategy: the sampler's internal mutex is poisoned, likely due to a panic in another thread holding the lock. This may result in using stale configuration until the remote sampling client is restarted.",
112+
message = "Unable to update Jaeger Remote sampling strategy: the sampler's internal mutex is poisoned, likely due to a panic in another thread holding the lock. The last known configuration will continue to be used until the remote sampling client is restarted.",
113113
);
114114
});
115115
}
@@ -141,7 +141,7 @@ impl Inner {
141141
_ => {
142142
otel_warn!(
143143
name: "Sampler.JaegerRemote.InvalidStrategy",
144-
message = "Received invalid sampling strategy from Jaeger remote endpoint. Expected one of: OperationSampling, RateLimitingSampling (max traces per second), or ProbabilisticSampling (0.0-1.0 sampling probability). No valid strategy was found in the response. Using previous strategy if available.",
144+
message: "Invalid sampling strategy received from the remote endpoint. Expected one of: OperationSampling, RateLimitingSampling, or ProbabilisticSampling. Continuing to use the previous strategy or default sampler until a successful update.",
145145
);
146146
None
147147
}

0 commit comments

Comments
 (0)