Skip to content

Commit a4fae95

Browse files
authored
Remove unnecessary flush from tests (#1622)
1 parent 9f0ac7d commit a4fae95

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

opentelemetry-sdk/src/logs/mod.rs

-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ mod tests {
3838
log_record.attributes = Some(attributes);
3939
logger.emit(log_record);
4040

41-
logger_provider.force_flush();
42-
4341
// Assert
4442
let exported_logs = exporter
4543
.get_emitted_logs()

opentelemetry-sdk/src/trace/mod.rs

+4-7
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ mod tests {
8080
span.add_event("test-event".to_string(), vec![]);
8181
});
8282

83-
provider.force_flush();
84-
8583
// Assert
8684
let exported_spans = exporter
8785
.get_finished_spans()
@@ -112,8 +110,10 @@ mod tests {
112110
span.set_attribute(KeyValue::new("attribute1", "value1"));
113111
span.add_event("test-event".to_string(), vec![]);
114112
span.set_status(Status::error("cancelled"));
115-
drop(span);
116-
provider.force_flush();
113+
span.end();
114+
115+
// After span end, further operations should not have any effect
116+
span.update_name("span_name_updated");
117117

118118
// Assert
119119
let exported_spans = exporter
@@ -150,7 +150,6 @@ mod tests {
150150
span.add_event("test-event".to_string(), vec![]);
151151
span.set_status(Status::Ok);
152152
drop(span);
153-
provider.force_flush();
154153

155154
// Assert
156155
let exported_spans = exporter
@@ -197,7 +196,6 @@ mod tests {
197196
let span_builder = SpanBuilder::from_name("span_name").with_links(links);
198197
let mut span = tracer.build(span_builder);
199198
span.end();
200-
provider.force_flush();
201199

202200
// Assert
203201
let exported_spans = exporter
@@ -233,7 +231,6 @@ mod tests {
233231
span.add_event("test event again, after span builder", Vec::new());
234232
span.add_event("test event once again, after span builder", Vec::new());
235233
span.end();
236-
provider.force_flush();
237234

238235
// Assert
239236
let exported_spans = exporter

0 commit comments

Comments
 (0)