Skip to content

Commit 9ea90ff

Browse files
committed
Remove env_logger from workspace.
- We don't want to include it in the top level workspace as it interferes with MSRV, and doesn't provide benefit. - For MSRV check we just run check. - Also bump to 0.11 in example. Relates #1546,#1554
1 parent 6952f29 commit 9ea90ff

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

.github/workflows/ci.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,9 @@ jobs:
9393
run: ./scripts/patch_dependencies.sh
9494
- name: Run tests
9595
run: cargo --version &&
96-
cargo test --manifest-path=opentelemetry/Cargo.toml --features trace,metrics,testing &&
97-
cargo test --manifest-path=opentelemetry-jaeger/Cargo.toml --features rt-tokio &&
98-
cargo test --manifest-path=opentelemetry-zipkin/Cargo.toml
96+
cargo check --lib --manifest-path=opentelemetry/Cargo.toml --features trace,metrics,testing &&
97+
cargo check --lib --manifest-path=opentelemetry-jaeger/Cargo.toml --features rt-tokio &&
98+
cargo check --lib --manifest-path=opentelemetry-zipkin/Cargo.toml
9999
cargo-deny:
100100
runs-on: ubuntu-latest
101101
continue-on-error: true # Prevent sudden announcement of a new advisory from failing ci

Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ debug = 1
2121
async-std = "1.10"
2222
async-trait = "0.1"
2323
bytes = "1"
24-
env_logger = { version = "0.10", default-features = false } # env_logger requires a newer MSRV
2524
futures-core = "0.3"
2625
futures-executor = "0.3"
2726
futures-util = { version = "0.3", default-features = false }

opentelemetry-jaeger/examples/actix-udp/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ opentelemetry-jaeger = { path = "../.." }
1111
opentelemetry_sdk = { path = "../../../opentelemetry-sdk" }
1212
actix-web = "4.1"
1313
actix-service = "2"
14-
env_logger = "0.10.0"
14+
env_logger = "0.11.0"

0 commit comments

Comments
 (0)