Skip to content

Commit 90bbb2d

Browse files
committed
remove leftover method
1 parent cc12da1 commit 90bbb2d

File tree

1 file changed

+4
-19
lines changed
  • opentelemetry-sdk/src/metrics/internal

1 file changed

+4
-19
lines changed

opentelemetry-sdk/src/metrics/internal/sum.rs

+4-19
Original file line numberDiff line numberDiff line change
@@ -67,21 +67,6 @@ impl<T: Number<T>> ValueMap<T> {
6767
// Use the 8 least significant bits directly, avoiding the modulus operation.
6868
hasher.finish() as u8 as usize
6969
}
70-
71-
// Calculate the total length of data points across all buckets.
72-
fn total_data_points_count(&self) -> usize {
73-
self.buckets
74-
.iter()
75-
.map(|bucket_mutex| {
76-
bucket_mutex.lock()
77-
.map(|locked_bucket| locked_bucket.as_ref().map_or(0, |bucket| bucket.len()))
78-
.unwrap_or_else(|_| {
79-
global::handle_error(MetricsError::Other("Failed to acquire lock on a bucket. Using default `0` as total data points.".into()));
80-
0
81-
})
82-
})
83-
.sum::<usize>()
84-
}
8570
}
8671

8772
impl<T: Number<T>> ValueMap<T> {
@@ -178,7 +163,7 @@ impl<T: Number<T>> Sum<T> {
178163
s_data.is_monotonic = self.monotonic;
179164
s_data.data_points.clear();
180165

181-
let total_len: usize = self.value_map.total_data_points_count() + 1;
166+
let total_len: usize = self.value_map.total_unique_entries.load(Ordering::Relaxed) + 1;
182167
if total_len > s_data.data_points.capacity() {
183168
let additional_space_needed = total_len - s_data.data_points.capacity();
184169
s_data.data_points.reserve_exact(additional_space_needed);
@@ -264,7 +249,7 @@ impl<T: Number<T>> Sum<T> {
264249
s_data.is_monotonic = self.monotonic;
265250
s_data.data_points.clear();
266251

267-
let total_len: usize = self.value_map.total_data_points_count() + 1;
252+
let total_len: usize = self.value_map.total_unique_entries.load(Ordering::Relaxed) + 1;
268253
if total_len > s_data.data_points.capacity() {
269254
let additional_space_needed = total_len - s_data.data_points.capacity();
270255
s_data.data_points.reserve_exact(additional_space_needed);
@@ -368,7 +353,7 @@ impl<T: Number<T>> PrecomputedSum<T> {
368353
s_data.temporality = Temporality::Delta;
369354
s_data.is_monotonic = self.monotonic;
370355

371-
let total_len: usize = self.value_map.total_data_points_count() + 1;
356+
let total_len: usize = self.value_map.total_unique_entries.load(Ordering::Relaxed) + 1;
372357
if total_len > s_data.data_points.capacity() {
373358
let additional_space_needed = total_len - s_data.data_points.capacity();
374359
s_data.data_points.reserve_exact(additional_space_needed);
@@ -465,7 +450,7 @@ impl<T: Number<T>> PrecomputedSum<T> {
465450
s_data.temporality = Temporality::Cumulative;
466451
s_data.is_monotonic = self.monotonic;
467452

468-
let total_len: usize = self.value_map.total_data_points_count() + 1;
453+
let total_len: usize = self.value_map.total_unique_entries.load(Ordering::Relaxed) + 1;
469454
if total_len > s_data.data_points.capacity() {
470455
let additional_space_needed = total_len - s_data.data_points.capacity();
471456
s_data.data_points.reserve_exact(additional_space_needed);

0 commit comments

Comments
 (0)