Simplify Get APIs

Author: utpilla

opentelemetry/src/baggage.rs

@@ -75,8 +75,8 @@ impl Baggage {
     ///
     /// assert_eq!(cc.get("my-name"), Some(&Value::from("my-value")))
     /// ```
-    pub fn get<T: Into<Key>>(&self, key: T) -> Option<&Value> {
-        self.inner.get(&key.into()).map(|(value, _metadata)| value)
+    pub fn get<K: AsRef<str>>(&self, key: K) -> Option<&Value> {
+        self.inner.get(key.as_ref()).map(|(value, _metadata)| value)
     }
 
     /// Returns a reference to the value and metadata associated with a given name
@@ -91,8 +91,8 @@ impl Baggage {
     /// // By default, the metadata is empty
     /// assert_eq!(cc.get_with_metadata("my-name"), Some(&(Value::from("my-value"), BaggageMetadata::from(""))))
     /// ```
-    pub fn get_with_metadata<T: Into<Key>>(&self, key: T) -> Option<&(Value, BaggageMetadata)> {
-        self.inner.get(&key.into())
+    pub fn get_with_metadata<K: AsRef<str>>(&self, key: K) -> Option<&(Value, BaggageMetadata)> {
+        self.inner.get(key.as_ref())
     }
 
     /// Inserts a name/value pair into the baggage.

opentelemetry/src/common.rs

@@ -1,4 +1,4 @@
-use std::borrow::Cow;
+use std::borrow::{Borrow, Cow};
 use std::sync::Arc;
 use std::{fmt, hash};
 
@@ -135,6 +135,18 @@ impl fmt::Display for Key {
     }
 }
 
+impl Borrow<str> for Key {
+    fn borrow(&self) -> &str {
+        self.0.as_str()
+    }
+}
+
+impl AsRef<str> for Key {
+    fn as_ref(&self) -> &str {
+        self.0.as_str()
+    }
+}
+
 #[derive(Clone, Debug, Eq)]
 enum OtelString {
     Owned(Box<str>),